Changeset 246188 in webkit

Timestamp:

Jun 6, 2019 10:46:03 PM (5 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r243094): [GTK][WPE] Stale content after restoring the web view session
​https://bugs.webkit.org/show_bug.cgi?id=198561

Reviewed by Chris Dumez.

This is another regression of delaying the web process launch until the first load. If the session is restored
before anything has been loaded, which is the normal way, the RestoreSession message is just ignored and the
state is sent to the WebPage on creation via creation parameters. The WebPage considers that restoring a session
from creation parameters only happens when re-launching a process after a crash or in case of process swap. In
those cases, the history item is not marked as restored from session. We need to ensure the session is restored
in the web process from the IPC message handler, by launching the initial process before the session is
restored.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::restoreFromSessionState):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r243094): [GTK][WPE] Stale content after restoring the web view session
+        https://bugs.webkit.org/show_bug.cgi?id=198561
+
+        Reviewed by Chris Dumez.
+
+        This is another regression of delaying the web process launch until the first load. If the session is restored
+        before anything has been loaded, which is the normal way, the RestoreSession message is just ignored and the
+        state is sent to the WebPage on creation via creation parameters. The WebPage considers that restoring a session
+        from creation parameters only happens when re-launching a process after a crash or in case of process swap. In
+        those cases, the history item is not marked as restored from session. We need to ensure the session is restored
+        in the web process from the IPC message handler, by launching the initial process before the session is
+        restored.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::restoreFromSessionState):
+
 2019-06-06  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -3084 +3084 @@
 
     if (hasBackForwardList) {
+        // If there isn't a running process yet the RestoreSession message below is just ignored, and
+        // session is restored when the web process is created via creation parameters which is not
+        // considered an API request. So, we launch the initial process here before restoring the
+        // session to ensure the session is restored in the web process via RestoreSession IPC message
+        // which is considered an API request. See https://bugs.webkit.org/show_bug.cgi?id=198561.
+        launchInitialProcessIfNecessary();
+
         m_backForwardList->restoreFromState(WTFMove(sessionState.backForwardListState));
         process().send(Messages::WebPage::RestoreSession(m_backForwardList->itemStates()), m_pageID);