Changeset 24619 in webkit


Ignore:
Timestamp:
Jul 25, 2007 2:57:02 AM (17 years ago)
Author:
bdash
Message:

Roll out r24618 as it broke 600+ layout tests.

Location:
trunk
Files:
6 deleted
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r24618 r24619  
    1 2007-07-24  Kevin McCullough  <kmccullough@apple.com>
    2 
    3         Reviewed by Oliver.
    4 
    5         - <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
    6         - Tests that feed:// urls can still be followed when clicked.
    7 
    8         * http/tests/security/feed-urls-from-remote-expected.txt: Added.
    9         * http/tests/security/feed-urls-from-remote.html: Added.
    10         * http/tests/security/resources/feed.html: Added.
    11         * http/tests/security/resources/feed.xml: Added.
    12         * win/Skipped:
    13 
    1412007-07-24  Brady Eidson <beidson@apple.com>
    152

  • trunk/WebCore/ChangeLog

    r24618 r24619  
    1 2007-07-24  Kevin McCullough  <kmccullough@apple.com>
    2 
    3         Reviewed by Oliver.
    4 
    5         - <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
    6         - Check for file:// urls when clicking links, not block all schemes that are treated as local.
    7 
    8         * loader/FrameLoader.cpp:
    9         (WebCore::FrameLoader::load):
    10 
    1112007-07-24  Oliver Hunt  <oliver@apple.com>
    122

  • trunk/WebCore/loader/FrameLoader.cpp

    r24618 r24619  
    18191819 
    18201820    ASSERT(frame()->document());
    1821 
    1822     const String& urlString = url.url().lower();
    1823     if (urlString.startsWith("file:")) {
    1824         FrameLoader::reportLocalLoadFailed(m_frame->page(), urlString);
     1821    if (!canLoad(url, frame()->document()) &&
     1822        !canLoad(url, referrer)) {
     1823        FrameLoader::reportLocalLoadFailed(m_frame->page(), url.url());
    18251824        return;
    18261825    }

  • trunk/WebKitTools/ChangeLog

    r24618 r24619  
    1 2007-07-24  Kevin McCullough  <kmccullough@apple.com>
    2 
    3         Reviewed by Oliver.
    4 
    5         - <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
    6         - Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
    7 
    8         * ChangeLog:
    9         * DumpRenderTree/DumpRenderTree.m:
    10         (createWebView):
    11         (dumpRenderTree):
    12         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
    13         (+[LayoutTestController webScriptNameForSelector:]):
    14         (-[LayoutTestController setCustomPolicyDelegate:]):
    15         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
    16         * DumpRenderTree/FrameLoadDelegate.h:
    17         * DumpRenderTree/PolicyDelegate.h: Added.
    18         * DumpRenderTree/PolicyDelegate.m: Added.
    19         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
    20         * DumpRenderTree/ResourceLoadDelegate.h:
    21 
    2212007-07-23  Adam Treat  <treat@kde.org>
    232

  • trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

    r24618 r24619  
    3636#import "ObjCPlugin.h"
    3737#import "ObjCPluginFunction.h"
    38 #import "PolicyDelegate.h"
    3938#import "ResourceLoadDelegate.h"
    4039#import "UIDelegate.h"
    … …  
    117116static EditingDelegate *editingDelegate;
    118117static ResourceLoadDelegate *resourceLoadDelegate;
    119 static PolicyDelegate *policyDelegate;
    120118
    121119// Deciding when it's OK to dump out the state is a bit tricky.  All these must be true:
    … …  
    383381    [webView setEditingDelegate:editingDelegate];
    384382    [webView setResourceLoadDelegate:resourceLoadDelegate];
    385 
    386     // Register the same schemes that Safari does
    387     [WebView registerURLSchemeAsLocal:@"feed"];
    388     [WebView registerURLSchemeAsLocal:@"feeds"];
    389     [WebView registerURLSchemeAsLocal:@"feedsearch"];
    390 
     383   
    391384    // The back/forward cache is causing problems due to layouts during transition from one page to another.
    392385    // So, turn it off for now, but we might want to turn it back on some day.
    … …  
    522515    editingDelegate = [[EditingDelegate alloc] init];   
    523516    resourceLoadDelegate = [[ResourceLoadDelegate alloc] init];
    524     policyDelegate = [[PolicyDelegate alloc] init];
    525517   
    526518    NSString *pwd = [[NSString stringWithUTF8String:argv[0]] stringByDeletingLastPathComponent];
    … …  
    595587    [resourceLoadDelegate release];
    596588    [uiDelegate release];
    597     [policyDelegate release];
    598589   
    599590    [localPasteboards release];
    … …  
    10121003            || aSelector == @selector(setCanOpenWindows)
    10131004            || aSelector == @selector(setCloseRemainingWindowsWhenComplete:)
    1014             || aSelector == @selector(setCustomPolicyDelegate:)
    10151005            || aSelector == @selector(setMainFrameIsFirstResponder:)
    10161006            || aSelector == @selector(setTabKeyCyclesThroughElements:)
    … …  
    10671057    if (aSelector == @selector(setCloseRemainingWindowsWhenComplete:))
    10681058        return @"setCloseRemainingWindowsWhenComplete";
    1069     if (aSelector == @selector(setCustomPolicyDelegate:))
    1070         return @"setCustomPolicyDelegate";
    10711059    if (aSelector == @selector(setUseDashboardCompatibilityMode:))
    10721060        return @"setUseDashboardCompatiblityMode";
    … …  
    11061094{
    11071095    closeRemainingWindowsWhenComplete = closeWindows;
    1108 }
    1109 
    1110 - (void)setCustomPolicyDelegate:(BOOL)setDelegate
    1111 {
    1112     if (setDelegate)
    1113         [[mainFrame webView] setPolicyDelegate:policyDelegate];
    1114     else
    1115         [[mainFrame webView] setPolicyDelegate:nil];
    11161096}
    11171097

  • trunk/WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

    r24618 r24619  
    6868                B5A752A008AF5CD400138E45 /* ImageDiff.m in Sources */ = {isa = PBXBuildFile; fileRef = B5A7525808AF4A3600138E45 /* ImageDiff.m */; };
    6969                B5A752A208AF5D1F00138E45 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = B5A752A108AF5D1F00138E45 /* QuartzCore.framework */; };
    70                 D23AE9660C56BB2100C47236 /* PolicyDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = D23AE8EA0C56B2FF00C47236 /* PolicyDelegate.m */; };
    71                 D23AE9690C56BB2900C47236 /* PolicyDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = D23AE8E00C56B29E00C47236 /* PolicyDelegate.h */; };
    7270                E1330800099624DA00AC0A91 /* AppleScriptController.h in Headers */ = {isa = PBXBuildFile; fileRef = E13307FE099624DA00AC0A91 /* AppleScriptController.h */; };
    7371                E1330801099624DA00AC0A91 /* AppleScriptController.m in Sources */ = {isa = PBXBuildFile; fileRef = E13307FF099624DA00AC0A91 /* AppleScriptController.m */; };
    … …  
    141139                B5A7526708AF4A4A00138E45 /* ImageDiff */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = ImageDiff; sourceTree = BUILT_PRODUCTS_DIR; };
    142140                B5A752A108AF5D1F00138E45 /* QuartzCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = QuartzCore.framework; path = /System/Library/Frameworks/QuartzCore.framework; sourceTree = "<absolute>"; };
    143                 D23AE8E00C56B29E00C47236 /* PolicyDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PolicyDelegate.h; sourceTree = "<group>"; };
    144                 D23AE8EA0C56B2FF00C47236 /* PolicyDelegate.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PolicyDelegate.m; sourceTree = "<group>"; };
    145141                E13307FE099624DA00AC0A91 /* AppleScriptController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AppleScriptController.h; sourceTree = "<group>"; };
    146142                E13307FF099624DA00AC0A91 /* AppleScriptController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = AppleScriptController.m; sourceTree = "<group>"; };
    … …  
    245241                                A803FFF309CAAFE0009B2A37 /* EditingDelegate.h */,
    246242                                A803FFF409CAAFE0009B2A37 /* EditingDelegate.m */,
    247                                 D23AE8E00C56B29E00C47236 /* PolicyDelegate.h */,
    248                                 D23AE8EA0C56B2FF00C47236 /* PolicyDelegate.m */,
    249243                                1A6CA8630B7120CF00A24B62 /* ResourceLoadDelegate.h */,
    250244                                1A6CA8640B7120CF00A24B62 /* ResourceLoadDelegate.m */,
    … …  
    315309                                6508A2990BFABB8100AD2696 /* FrameLoadDelegate.h in Headers */,
    316310                                6508A29A0BFABB8200AD2696 /* ResourceLoadDelegate.h in Headers */,
    317                                 D23AE9690C56BB2900C47236 /* PolicyDelegate.h in Headers */,
    318311                        );
    319312                        runOnlyForDeploymentPostprocessing = 0;
    … …  
    442435                                1422A1BB0AF6EDD600E1A883 /* UIDelegate.m in Sources */,
    443436                                6508A2980BFABB8000AD2696 /* FrameLoadDelegate.m in Sources */,
    444                                 D23AE9660C56BB2100C47236 /* PolicyDelegate.m in Sources */,
    445437                        );
    446438                        runOnlyForDeploymentPostprocessing = 0;

  • trunk/WebKitTools/DumpRenderTree/FrameLoadDelegate.h

    r24618 r24619  
    11/*
    2  * Copyright (C) 2007 Apple Inc.  All rights reserved.
     2 * Copyright (C) 2007, Apple Inc.  All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without

  • trunk/WebKitTools/DumpRenderTree/ResourceLoadDelegate.h

    r24618 r24619  
    11/*
    2  * Copyright (C) 2007 Apple Inc.  All rights reserved.
     2 * Copyright (C) 2007, Apple Inc.  All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
Note: See TracChangeset for help on using the changeset viewer.