Changeset 246212 in webkit

Timestamp:

Jun 7, 2019 1:08:38 PM (5 years ago)

Author:

youenn@apple.com

Message:

A MediaStreamTrack cannot modify whether being a capture track or not
​https://bugs.webkit.org/show_bug.cgi?id=198669

Reviewed by Eric Carlson.

Add a boolean in MediaStreamTrack to store whether a track is a capture one or not.
This removes the need to always go through the private and its source.
As a track might change of source (for non capture track cases), this
also removes the possibility for a track to be capture and then no
longer capture.
No change of behavior.
See also rdar://problem/49444622.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):

• Modules/mediastream/MediaStreamTrack.h:

(WebCore::MediaStreamTrack::isCaptureTrack const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/MediaStreamTrack.cpp (modified) (1 diff)
• Modules/mediastream/MediaStreamTrack.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-07  Youenn Fablet  <youenn@apple.com>
+
+        A MediaStreamTrack cannot modify whether being a capture track or not
+        https://bugs.webkit.org/show_bug.cgi?id=198669
+
+        Reviewed by Eric Carlson.
+
+        Add a boolean in MediaStreamTrack to store whether a track is a capture one or not.
+        This removes the need to always go through the private and its source.
+        As a track might change of source (for non capture track cases), this
+        also removes the possibility for a track to be capture and then no
+        longer capture.
+        No change of behavior.
+        See also rdar://problem/49444622.
+
+        * Modules/mediastream/MediaStreamTrack.cpp:
+        (WebCore::MediaStreamTrack::MediaStreamTrack):
+        * Modules/mediastream/MediaStreamTrack.h:
+        (WebCore::MediaStreamTrack::isCaptureTrack const):
+
 2019-06-07  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp

@@ -64 +64 @@
 #endif
     , m_taskQueue(context)
+    , m_isCaptureTrack(m_private->isCaptureTrack())
 {
     ALWAYS_LOG(LOGIDENTIFIER);

trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h

@@ -94 +94 @@
     void stopTrack(StopMode = StopMode::Silently);
 
-    bool isCaptureTrack() const { return m_private->isCaptureTrack(); }
+    bool isCaptureTrack() const { return m_isCaptureTrack; }
 
     struct TrackSettings {
@@ -203 +203 @@
 
     bool m_ended { false };
+    bool m_isCaptureTrack { false };
 };