Changeset 246227 in webkit

Timestamp:

Jun 7, 2019 6:30:46 PM (5 years ago)

Author:

youenn@apple.com

Message:

[ Mac Debug ] REGRESSION (r242975) Layout Test storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196445
<rdar://problem/49483061>

Reviewed by Brady Eidson.

Unflake the test by making sure to wait for the onerror event before continuing the test.

• platform/mac-wk2/TestExpectations:
• storage/indexeddb/modern/resources/deletedatabase-2.js:

(prepareDatabase.event.target.onerror):
(continueTest1.request.onsuccess): Deleted.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac-wk2/TestExpectations (modified) (1 diff)
• storage/indexeddb/modern/resources/deletedatabase-2.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-07  Youenn Fablet  <youenn@apple.com>
+
+        [ Mac Debug ] REGRESSION (r242975) Layout Test storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=196445
+        <rdar://problem/49483061>
+
+        Reviewed by Brady Eidson.
+
+        Unflake the test by making sure to wait for the onerror event before continuing the test.
+
+        * platform/mac-wk2/TestExpectations:
+        * storage/indexeddb/modern/resources/deletedatabase-2.js:
+        (prepareDatabase.event.target.onerror):
+        (continueTest1.request.onsuccess): Deleted.
+
 2019-06-07  Truitt Savell  <tsavell@apple.com>
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -951 +951 @@
 webkit.org/b/189672 [ Mojave Debug ] webgl/2.0.0/conformance2/textures/misc/tex-new-formats.html [ Skip ]
 
-webkit.org/b/196445 [ Debug ] storage/indexeddb/modern/deletedatabase-2-private.html [ Pass Failure ]
-
 webkit.org/b/198195 [ Release ] fast/css/sticky/sticky-left-percentage.html [ Pass ImageOnlyFailure ]
 

trunk/LayoutTests/storage/indexeddb/modern/resources/deletedatabase-2.js

@@ -22 +22 @@
 
 var dbname;
+var resolveTransactionPromise;
+var transactionPromise = new Promise(resolve => resolveTransactionPromise = resolve);
+
 function prepareDatabase(e)
 {
@@ -28 +31 @@
     event.target.onerror = function(e) {
         debug("Open request error: " + event.target.error.name);
+        resolveTransactionPromise();
     }
 
@@ -77 +81 @@
     debug("Requesting deleteDatabase");
     var request = window.indexedDB.deleteDatabase(dbname);
-    request.onsuccess = function(e)
+    request.onsuccess = async function(e)
     {
+        await transactionPromise;
         debug("Delete database success: oldVersion " + e.oldVersion + ", newVersion " + e.newVersion);
         continueTest2();