Changeset 246271 in webkit

Timestamp:

Jun 10, 2019 12:32:00 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: "Copy Path to Property" doesn't work with multiline keys
​https://bugs.webkit.org/show_bug.cgi?id=198691

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-06-10
Reviewed by Matt Baker.

Correctly escape line terminators to prevent doubleQuotedString from returning malformed strings.

• UserInterface/Base/Utilities.js: Use JSON.stringify.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Utilities.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-06-10  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Web Inspector: "Copy Path to Property" doesn't work with multiline keys
+        https://bugs.webkit.org/show_bug.cgi?id=198691
+
+        Reviewed by Matt Baker.
+
+        Correctly escape line terminators to prevent doubleQuotedString from returning malformed strings.
+
+        * UserInterface/Base/Utilities.js: Use JSON.stringify.
+
 2019-06-10  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js

@@ -1638 +1638 @@
 function doubleQuotedString(str)
 {
-    return "\"" + str.replace(/\\/g, "\\\\").replace(/"/g, "\\\"") + "\"";
+    return JSON.stringify(str);
 }