Changeset 246282 in webkit


Ignore:
Timestamp:
Jun 10, 2019 2:35:13 PM (5 years ago)
Author:
Ryan Haddad
Message:

Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
​https://bugs.webkit.org/show_bug.cgi?id=198616
rdar://problem/36386573

Patch by Alexey Proskuryakov <​ap@apple.com> on 2019-06-10
Reviewed by David Kilzer.

Adding an explicit STRIP_STYLE to appropriate xcconfigs.

  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
  • DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
  • ImageDiff/cg/Configurations/ImageDiff.xcconfig:
  • MiniBrowser/Configurations/MiniBrowser.xcconfig:
  • MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
  • TestWebKitAPI/Configurations/TestWTF.xcconfig:
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
Location:
trunk/Tools
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r246276 r246282  
     12019-06-10  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
     4        https://bugs.webkit.org/show_bug.cgi?id=198616
     5        rdar://problem/36386573
     6
     7        Reviewed by David Kilzer.
     8
     9        Adding an explicit STRIP_STYLE to appropriate xcconfigs.
     10
     11        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
     12        * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
     13        * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
     14        * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
     15        * MiniBrowser/Configurations/MiniBrowser.xcconfig:
     16        * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
     17        * TestWebKitAPI/Configurations/TestWTF.xcconfig:
     18        * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
     19        * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
     20        * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
     21
    1222019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
    223

  • trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig

    r222897 r246282  
    2828PLATFORM_OTHER_LDFLAGS[sdk=macosx*] = -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework Carbon -framework Cocoa -framework JavaScriptCore -framework OpenGL -framework QuartzCore -framework WebKit;
    2929LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";
     30STRIP_STYLE = debugging;
    3031PRODUCT_NAME = DumpRenderTree;
    3132SKIP_INSTALL[sdk=macosx*] = NO;

  • trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig

    r222897 r246282  
    3232PLATFORM_OTHER_LDFLAGS[sdk=macosx*] = -framework JavaScriptCore;
    3333
     34STRIP_STYLE = debugging;
     35
    3436LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";
    3537

  • trunk/Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig

    r184209 r246282  
    2727
    2828OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;
     29STRIP_STYLE = debugging;

  • trunk/Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig

    r216207 r246282  
    2929OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework QuartzCore;
    3030OTHER_LDFLAGS[sdk=iphone*] = $(inherited) -framework CoreFoundation -framework CoreGraphics -framework MobileCoreServices -framework ImageIO;
     31STRIP_STYLE = debugging;

  • trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig

    r227908 r246282  
    2929EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *
    3030OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Cocoa -framework WebKit
     31STRIP_STYLE = debugging;

  • trunk/Tools/MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig

    r205353 r246282  
    2323
    2424PRODUCT_NAME = MiniBrowser
     25
     26STRIP_STYLE=debugging

  • trunk/Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig

    r215424 r246282  
    3737// FIXME: This should not be built on iOS. Instead we should create and use a TestWTF application.
    3838OTHER_LDFLAGS_PLATFORM[sdk=iphone*] = -framework CoreGraphics;
     39
     40STRIP_STYLE = debugging;

  • trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig

    r220536 r246282  
    3838
    3939CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = Configurations/TestWebKitAPI-iOS.entitlements;
     40
     41STRIP_STYLE = debugging;

  • trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig

    r222897 r246282  
    3131GCC_ENABLE_OBJC_EXCEPTIONS = YES;
    3232OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -lWebKitTestRunner -framework Carbon -framework Cocoa -framework JavaScriptCore -framework WebKit;
     33STRIP_STYLE = debugging;
    3334SKIP_INSTALL[sdk=iphone*] = YES;
    3435EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = mac/*;

  • trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig

    r244220 r246282  
    3333OTHER_LDFLAGS = $(inherited) -lWebKitTestRunner -lWebCoreTestSupport -framework JavaScriptCore -framework CoreGraphics -framework QuartzCore -framework ImageIO -framework IOKit -framework UIKit -framework WebKit -framework Foundation -framework GraphicsServices;
    3434
     35STRIP_STYLE = debugging;
     36
    3537SKIP_INSTALL[sdk=macosx*] = YES;
    3638
Note: See TracChangeset for help on using the changeset viewer.