Changeset 246292 in webkit

Timestamp:

Jun 10, 2019 4:15:41 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Timelines: imported recordings do not have JavaScript call trees
​https://bugs.webkit.org/show_bug.cgi?id=197490
<rdar://problem/50589158>

Reviewed by Joseph Pecoraro.

• UserInterface/Models/TimelineRecording.js:

(WI.TimelineRecording.prototype.initializeCallingContextTrees):
Make sure to actually save the provided stack traces and samples in the export data.

• UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.fromJSON):
(WI.ScriptTimelineRecord.prototype.toJSON):
Drive-by: include extraDetails, which contains useful information like "default prevented".

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/ScriptTimelineRecord.js (modified) (3 diffs)
• UserInterface/Models/TimelineRecording.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-06-10  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Timelines: imported recordings do not have JavaScript call trees
+        https://bugs.webkit.org/show_bug.cgi?id=197490
+        <rdar://problem/50589158>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Models/TimelineRecording.js:
+        (WI.TimelineRecording.prototype.initializeCallingContextTrees):
+        Make sure to actually save the provided stack traces and samples in the export data.
+
+        * UserInterface/Models/ScriptTimelineRecord.js:
+        (WI.ScriptTimelineRecord.fromJSON):
+        (WI.ScriptTimelineRecord.prototype.toJSON):
+        Drive-by: include `extraDetails`, which contains useful information like "default prevented".
+
 2019-06-10  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js

@@ -54 +54 @@
     static fromJSON(json)
     {
-        let {eventType, startTime, endTime, callFrames, sourceCodeLocation, details, profilePayload} = json;
+        let {eventType, startTime, endTime, callFrames, sourceCodeLocation, details, profilePayload, extraDetails} = json;
 
         if (typeof details === "object" && details.__type === "GarbageCollection")
             details = WI.GarbageCollection.fromJSON(details);
 
-        return new WI.ScriptTimelineRecord(eventType, startTime, endTime, callFrames, sourceCodeLocation, details, profilePayload);
+        return new WI.ScriptTimelineRecord(eventType, startTime, endTime, callFrames, sourceCodeLocation, details, profilePayload, extraDetails);
     }
 
@@ -66 +66 @@
         // FIXME: CallFrames
         // FIXME: SourceCodeLocation
+        // FIXME: profilePayload
 
         return {
@@ -73 +74 @@
             endTime: this.endTime,
             details: this._details,
+            extraDetails: this._extraDetails,
         };
     }

trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js

@@ -432 +432 @@
     initializeCallingContextTrees(stackTraces, sampleDurations)
     {
-        this._exportDataSampleStackTraces.concat(stackTraces);
-        this._exportDataSampleDurations.concat(sampleDurations);
+        this._exportDataSampleStackTraces = this._exportDataSampleStackTraces.concat(stackTraces);
+        this._exportDataSampleDurations = this._exportDataSampleDurations.concat(sampleDurations);
 
         for (let i = 0; i < stackTraces.length; i++) {