Changeset 246316 in webkit

Timestamp:

Jun 11, 2019 8:55:17 AM (5 years ago)

Author:

Antti Koivisto

Message:

REGRESSION (iOS): Can't scroll litter-robot.com checkout form's dropdown menus
​https://bugs.webkit.org/show_bug.cgi?id=198753
<rdar://problem/51355686>

Reviewed by Simon Fraser.

Source/WebKit:

If an element with 'overflow:scroll' also had 'visibility:hidden' or 'pointer-events:none' it would
capture touches and prevent scrolling of any overlapped scrollers.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(WebKit::collectDescendantViewsAtPoint):

Filter out views with 'isUserInteractionEnabled == NO' (set for hidden and pointer-events:none layers).
This prevents it being considered as the first view hit when determining scrolling relationships.

(-[UIView _web_findDescendantViewAtPoint:withEvent:]):

No need to skip here anymore.

LayoutTests:

• fast/scrolling/ios/overflow-scroll-user-interaction-disabled-expected.txt: Added.
• fast/scrolling/ios/overflow-scroll-user-interaction-disabled.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/ios/overflow-scroll-user-interaction-disabled-expected.txt (added)
• LayoutTests/fast/scrolling/ios/overflow-scroll-user-interaction-disabled.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-11  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (iOS): Can't scroll litter-robot.com checkout form's dropdown menus
+        https://bugs.webkit.org/show_bug.cgi?id=198753
+        <rdar://problem/51355686>
+
+        Reviewed by Simon Fraser.
+
+        * fast/scrolling/ios/overflow-scroll-user-interaction-disabled-expected.txt: Added.
+        * fast/scrolling/ios/overflow-scroll-user-interaction-disabled.html: Added.
+
 2019-06-11  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-11  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (iOS): Can't scroll litter-robot.com checkout form's dropdown menus
+        https://bugs.webkit.org/show_bug.cgi?id=198753
+        <rdar://problem/51355686>
+
+        Reviewed by Simon Fraser.
+
+        If an element with 'overflow:scroll' also had 'visibility:hidden' or 'pointer-events:none' it would
+        capture touches and prevent scrolling of any overlapped scrollers.
+
+        * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
+        (WebKit::collectDescendantViewsAtPoint):
+
+        Filter out views with 'isUserInteractionEnabled == NO' (set for hidden and pointer-events:none layers).
+        This prevents it being considered as the first view hit when determining scrolling relationships.
+
+        (-[UIView _web_findDescendantViewAtPoint:withEvent:]):
+
+        No need to skip here anymore.
+
 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm

@@ -48 +48 @@
 
         auto handlesEvent = [&] {
+            // FIXME: isUserInteractionEnabled is mostly redundant with event regions for web content layers.
+            //        It is currently only needed for scroll views.
+            if (!view.isUserInteractionEnabled)
+                return false;
             if (![view pointInside:subviewPoint withEvent:event])
                 return false;
@@ -134 +138 @@
 
     for (auto *view : WTF::makeReversedRange(viewsAtPoint)) {
-        if (!view.isUserInteractionEnabled)
-            continue;
-
         if ([view conformsToProtocol:@protocol(WKNativelyInteractible)]) {
             CGPoint subviewPoint = [view convertPoint:point fromView:self];