Changeset 246320 in webkit

Timestamp:

Jun 11, 2019 9:42:39 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: AXI: Audit: image label test is throwing spurious errors on elements with existing alt attr, but no value: <img alt>
​https://bugs.webkit.org/show_bug.cgi?id=194754
<rdar://problem/48144534>

Patch by Greg Doolittle <​gr3g@apple.com> on 2019-06-11
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/img-alt-attribute-empty-string.html

accessibility/img-alt-attribute-no-value.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::computedRoleString const):

LayoutTests:

• accessibility/img-alt-attribute-empty-string-expected.txt: Added.
• accessibility/img-alt-attribute-empty-string.html: Added.
• accessibility/img-alt-attribute-no-value-expected.txt: Added.
• accessibility/img-alt-attribute-no-value.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/img-alt-attribute-empty-string-expected.txt (added)
• LayoutTests/accessibility/img-alt-attribute-empty-string.html (added)
• LayoutTests/accessibility/img-alt-attribute-no-value-expected.txt (added)
• LayoutTests/accessibility/img-alt-attribute-no-value.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-11  Greg Doolittle  <gr3g@apple.com>
+
+        Web Inspector: AXI: Audit: image label test is throwing spurious errors on elements with existing alt attr, but no value: <img alt>
+        https://bugs.webkit.org/show_bug.cgi?id=194754
+        <rdar://problem/48144534>
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/img-alt-attribute-empty-string-expected.txt: Added.
+        * accessibility/img-alt-attribute-empty-string.html: Added.
+        * accessibility/img-alt-attribute-no-value-expected.txt: Added.
+        * accessibility/img-alt-attribute-no-value.html: Added.
+
 2019-06-11  Shawn Roberts  <sroberts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-11  Greg Doolittle  <gr3g@apple.com>
+
+        Web Inspector: AXI: Audit: image label test is throwing spurious errors on elements with existing alt attr, but no value: <img alt>
+        https://bugs.webkit.org/show_bug.cgi?id=194754
+        <rdar://problem/48144534>
+
+        Reviewed by Chris Fleizach.
+
+        Tests: accessibility/img-alt-attribute-empty-string.html
+               accessibility/img-alt-attribute-no-value.html
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::computedRoleString const):
+
 2019-06-11  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -2494 +2494 @@
     AccessibilityRole role = roleValue();
 
+    if (accessibilityIsIgnored())
+        return reverseAriaRoleMap().get(static_cast<int>(AccessibilityRole::Presentational));
+
     // We do not compute a role string for generic block elements with user-agent assigned roles.
     if (role == AccessibilityRole::Group || role == AccessibilityRole::TextGroup)