Changeset 246340 in webkit

Timestamp:

Jun 11, 2019 4:40:08 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r246320.
​https://bugs.webkit.org/show_bug.cgi?id=198773

New test is failing, and commit is causing another test to
fail. (Requested by ShawnRoberts on #webkit).

Reverted changeset:

"Web Inspector: AXI: Audit: image label test is throwing
spurious errors on elements with existing alt attr, but no
value: <img alt>"
​https://bugs.webkit.org/show_bug.cgi?id=194754
​https://trac.webkit.org/changeset/246320

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/img-alt-attribute-empty-string-expected.txt (deleted)
• LayoutTests/accessibility/img-alt-attribute-empty-string.html (deleted)
• LayoutTests/accessibility/img-alt-attribute-no-value-expected.txt (deleted)
• LayoutTests/accessibility/img-alt-attribute-no-value.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r246320.
+        https://bugs.webkit.org/show_bug.cgi?id=198773
+
+        New test is failing, and commit is causing another test to
+        fail. (Requested by ShawnRoberts on #webkit).
+
+        Reverted changeset:
+
+        "Web Inspector: AXI: Audit: image label test is throwing
+        spurious errors on elements with existing alt attr, but no
+        value: <img alt>"
+        https://bugs.webkit.org/show_bug.cgi?id=194754
+        https://trac.webkit.org/changeset/246320
+
 2019-06-11  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r246320.
+        https://bugs.webkit.org/show_bug.cgi?id=198773
+
+        New test is failing, and commit is causing another test to
+        fail. (Requested by ShawnRoberts on #webkit).
+
+        Reverted changeset:
+
+        "Web Inspector: AXI: Audit: image label test is throwing
+        spurious errors on elements with existing alt attr, but no
+        value: <img alt>"
+        https://bugs.webkit.org/show_bug.cgi?id=194754
+        https://trac.webkit.org/changeset/246320
+
 2019-06-11  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -2494 +2494 @@
     AccessibilityRole role = roleValue();
 
-    if (accessibilityIsIgnored())
-        return reverseAriaRoleMap().get(static_cast<int>(AccessibilityRole::Presentational));
-
     // We do not compute a role string for generic block elements with user-agent assigned roles.
     if (role == AccessibilityRole::Group || role == AccessibilityRole::TextGroup)