Changeset 246384 in webkit

Timestamp:

Jun 12, 2019 3:46:14 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: artificial context menus don't work when Web Inspector is zoomed
​https://bugs.webkit.org/show_bug.cgi?id=198801

Reviewed by Joseph Pecoraro.

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
Use the absoluteLocation of the MouseEvent, which takes into account zoom and scale.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorFrontendHost.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-12  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: artificial context menus don't work when Web Inspector is zoomed
+        https://bugs.webkit.org/show_bug.cgi?id=198801
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/InspectorFrontendHost.cpp:
+        (WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
+        Use the `absoluteLocation` of the `MouseEvent`, which takes into account zoom and scale.
+
 2019-06-12  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp

@@ -427 +427 @@
 
     auto& mouseEvent = downcast<MouseEvent>(event);
-    IntPoint mousePoint { mouseEvent.clientX(), mouseEvent.clientY() };
     auto& frame = *downcast<Node>(mouseEvent.target())->document().frame();
-
-    m_frontendPage->contextMenuController().showContextMenuAt(frame, mousePoint);
+    m_frontendPage->contextMenuController().showContextMenuAt(frame, roundedIntPoint(mouseEvent.absoluteLocation()));
 #else
     UNUSED_PARAM(event);