Changeset 246405 in webkit

Timestamp:

Jun 13, 2019 11:14:31 AM (5 years ago)

Author:

youenn@apple.com

Message:

SocketStreamHandle should not be destroyed in a background thread
​https://bugs.webkit.org/show_bug.cgi?id=198781

Reviewed by Geoffrey Garen.

Make sure to destroy SocketStreamHandle on the main thread since it owns an URL created on the main thread.
Covered by WPT websocket tests from ​https://bugs.webkit.org/show_bug.cgi?id=198774.

• platform/network/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

• platform/network/SocketStreamHandle.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/SocketStreamHandle.cpp (modified) (1 diff)
• platform/network/SocketStreamHandle.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-13  Youenn Fablet  <youenn@apple.com>
+
+        SocketStreamHandle should not be destroyed in a background thread
+        https://bugs.webkit.org/show_bug.cgi?id=198781
+
+        Reviewed by Geoffrey Garen.
+
+        Make sure to destroy SocketStreamHandle on the main thread since it owns an URL created on the main thread.
+        Covered by WPT websocket tests from https://bugs.webkit.org/show_bug.cgi?id=198774.
+
+        * platform/network/SocketStreamHandle.cpp:
+        (WebCore::SocketStreamHandle::SocketStreamHandle):
+        * platform/network/SocketStreamHandle.h:
+
 2019-06-13  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/platform/network/SocketStreamHandle.cpp

@@ -43 +43 @@
     , m_state(Connecting)
 {
+    ASSERT(isMainThread());
 }
 

trunk/Source/WebCore/platform/network/SocketStreamHandle.h

@@ -48 +48 @@
 } SourceApplicationAuditToken;
 
-class SocketStreamHandle : public ThreadSafeRefCounted<SocketStreamHandle> {
+class SocketStreamHandle : public ThreadSafeRefCounted<SocketStreamHandle, WTF::DestructionThread::Main> {
 public:
     enum SocketStreamState { Connecting, Open, Closing, Closed };