Changeset 246410 in webkit

Timestamp:

Jun 13, 2019 1:00:01 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Settings: sticky header disappears when over scrolling
​https://bugs.webkit.org/show_bug.cgi?id=198833

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings .navigation-bar):
(.content-view.settings > .settings-view): Added.
(.content-view.settings): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.css (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-06-13  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Settings: sticky header disappears when over scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=198833
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/SettingsTabContentView.css:
+        (.content-view.settings .navigation-bar):
+        (.content-view.settings > .settings-view): Added.
+        (.content-view.settings): Deleted.
+
 2019-06-10  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css

@@ -25 +25 @@
  */
 
-.content-view.settings {
-    padding-bottom: 6vh;
-    overflow-y: auto;
-}
-
 .content-view.settings .navigation-bar {
-    position: sticky;
-    top: 0;
-    z-index: 1;
     background-color: white;
 }
@@ -52 +44 @@
 .content-view.settings .navigation-bar .item.radio.button.text-only.selected {
     color: var(--selected-background-color)
+}
+
+.content-view.settings > .settings-view {
+    height: 100%;
+    overflow-y: auto;
+    padding-bottom: calc(var(--console-prompt-min-height) + 10px);
 }