Changeset 246415 in webkit

Timestamp:

Jun 13, 2019 2:26:33 PM (5 years ago)

Author:

jer.noble@apple.com

Message:

AVKit play button bypasses MediaElementSession playbackPermitted() checks.
​https://bugs.webkit.org/show_bug.cgi?id=198813

Reviewed by Eric Carlson.

HTMLMediaElement::togglePlayState() is an internal-only method that doesn't
run playbackPermitted() checks. For our imitation AVPlayerController, translate
requests to -togglePlayback: into calls to play() and pause() depending on
playback state.

• platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController togglePlayback:]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebAVPlayerController.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-13  Jer Noble  <jer.noble@apple.com>
+
+        AVKit play button bypasses MediaElementSession playbackPermitted() checks.
+        https://bugs.webkit.org/show_bug.cgi?id=198813
+
+        Reviewed by Eric Carlson.
+
+        HTMLMediaElement::togglePlayState() is an internal-only method that doesn't
+        run playbackPermitted() checks. For our imitation AVPlayerController, translate
+        requests to -togglePlayback: into calls to play() and pause() depending on
+        playback state.
+
+        * platform/ios/WebAVPlayerController.mm:
+        (-[WebAVPlayerController togglePlayback:]):
+
 2019-06-13  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm

@@ -127 +127 @@
 {
     UNUSED_PARAM(sender);
-    if (self.delegate)
-        self.delegate->togglePlayState();
+    if (!self.delegate)
+        return;
+
+    if (self.delegate->isPlaying())
+        self.delegate->pause();
+    else
+        self.delegate->play();
 }