Changeset 246470 in webkit

Timestamp:

Jun 15, 2019 9:47:05 PM (5 years ago)

Author:

youenn@apple.com

Message:

Make MediaStream constructor take a Document instead of a ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=198873

Reviewed by Darin Adler.

Update MediaStream constructors and call site to take a Document&.
Make the same for creation of CanvasCaptureMediaStreamTrack.
No observable change of behavior.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::create):
(WebCore::CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack):
(WebCore::loggerFromContext): Deleted.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::loggerFromContext): Deleted.

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::captureStream):

• html/HTMLCanvasElement.h:
• html/HTMLCanvasElement.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp (modified) (2 diffs)
• Modules/mediastream/CanvasCaptureMediaStreamTrack.h (modified) (2 diffs)
• Modules/mediastream/MediaStream.cpp (modified) (5 diffs)
• Modules/mediastream/MediaStream.h (modified) (2 diffs)
• Modules/mediastream/MediaStream.idl (modified) (1 diff)
• Modules/mediastream/UserMediaRequest.cpp (modified) (1 diff)
• html/HTMLCanvasElement.cpp (modified) (1 diff)
• html/HTMLCanvasElement.h (modified) (1 diff)
• html/HTMLCanvasElement.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-15  Youenn Fablet  <youenn@apple.com>
+
+        Make MediaStream constructor take a Document instead of a ScriptExecutionContext
+        https://bugs.webkit.org/show_bug.cgi?id=198873
+
+        Reviewed by Darin Adler.
+
+        Update MediaStream constructors and call site to take a Document&.
+        Make the same for creation of CanvasCaptureMediaStreamTrack.
+        No observable change of behavior.
+
+        * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
+        (WebCore::CanvasCaptureMediaStreamTrack::create):
+        (WebCore::CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack):
+        (WebCore::loggerFromContext): Deleted.
+        * Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
+        * Modules/mediastream/MediaStream.cpp:
+        (WebCore::MediaStream::create):
+        (WebCore::MediaStream::MediaStream):
+        (WebCore::MediaStream::clone):
+        (WebCore::loggerFromContext): Deleted.
+        * Modules/mediastream/MediaStream.h:
+        * Modules/mediastream/MediaStream.idl:
+        * Modules/mediastream/UserMediaRequest.cpp:
+        (WebCore::UserMediaRequest::allow):
+        * html/HTMLCanvasElement.cpp:
+        (WebCore::HTMLCanvasElement::captureStream):
+        * html/HTMLCanvasElement.h:
+        * html/HTMLCanvasElement.idl:
+
 2019-06-15  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp

@@ -37 +37 @@
 WTF_MAKE_ISO_ALLOCATED_IMPL(CanvasCaptureMediaStreamTrack);
 
-Ref<CanvasCaptureMediaStreamTrack> CanvasCaptureMediaStreamTrack::create(ScriptExecutionContext& context, Ref<HTMLCanvasElement>&& canvas, Optional<double>&& frameRequestRate)
+Ref<CanvasCaptureMediaStreamTrack> CanvasCaptureMediaStreamTrack::create(Document& document, Ref<HTMLCanvasElement>&& canvas, Optional<double>&& frameRequestRate)
 {
     auto source = CanvasCaptureMediaStreamTrack::Source::create(canvas.get(), WTFMove(frameRequestRate));
-    return adoptRef(*new CanvasCaptureMediaStreamTrack(context, WTFMove(canvas), WTFMove(source)));
-}
-
-static inline Ref<const Logger> loggerFromContext(ScriptExecutionContext& context)
-{
-    return downcast<Document>(context).logger();
-}
-
-CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack(ScriptExecutionContext& context, Ref<HTMLCanvasElement>&& canvas, Ref<CanvasCaptureMediaStreamTrack::Source>&& source)
-    : MediaStreamTrack(context, MediaStreamTrackPrivate::create(loggerFromContext(context), source.copyRef()))
+    return adoptRef(*new CanvasCaptureMediaStreamTrack(document, WTFMove(canvas), WTFMove(source)));
+}
+
+CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack(Document& document, Ref<HTMLCanvasElement>&& canvas, Ref<CanvasCaptureMediaStreamTrack::Source>&& source)
+    : MediaStreamTrack(document, MediaStreamTrackPrivate::create(document.logger(), source.copyRef()))
     , m_canvas(WTFMove(canvas))
 {
 }
 
-CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack(ScriptExecutionContext& context, Ref<HTMLCanvasElement>&& canvas, Ref<MediaStreamTrackPrivate>&& privateTrack)
-    : MediaStreamTrack(context, WTFMove(privateTrack))
+CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack(Document& document, Ref<HTMLCanvasElement>&& canvas, Ref<MediaStreamTrackPrivate>&& privateTrack)
+    : MediaStreamTrack(document, WTFMove(privateTrack))
     , m_canvas(WTFMove(canvas))
 {
@@ -199 +194 @@
         return nullptr;
     
-    return adoptRef(*new CanvasCaptureMediaStreamTrack(*scriptExecutionContext(), m_canvas.copyRef(), m_private->clone()));
+    return adoptRef(*new CanvasCaptureMediaStreamTrack(downcast<Document>(*scriptExecutionContext()), m_canvas.copyRef(), m_private->clone()));
 }
 

trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h

@@ -34 +34 @@
 namespace WebCore {
 
+class Document;
 class HTMLCanvasElement;
 class Image;
-class ScriptExecutionContext;
 
 class CanvasCaptureMediaStreamTrack final : public MediaStreamTrack {
     WTF_MAKE_ISO_ALLOCATED(CanvasCaptureMediaStreamTrack);
 public:
-    static Ref<CanvasCaptureMediaStreamTrack> create(ScriptExecutionContext&, Ref<HTMLCanvasElement>&&, Optional<double>&& frameRequestRate);
+    static Ref<CanvasCaptureMediaStreamTrack> create(Document&, Ref<HTMLCanvasElement>&&, Optional<double>&& frameRequestRate);
 
     HTMLCanvasElement& canvas() { return m_canvas.get(); }
@@ -83 +83 @@
     };
 
-    CanvasCaptureMediaStreamTrack(ScriptExecutionContext&, Ref<HTMLCanvasElement>&&, Ref<Source>&&);
-    CanvasCaptureMediaStreamTrack(ScriptExecutionContext&, Ref<HTMLCanvasElement>&&, Ref<MediaStreamTrackPrivate>&&);
+    CanvasCaptureMediaStreamTrack(Document&, Ref<HTMLCanvasElement>&&, Ref<Source>&&);
+    CanvasCaptureMediaStreamTrack(Document&, Ref<HTMLCanvasElement>&&, Ref<MediaStreamTrackPrivate>&&);
 
     bool isCanvas() const final { return true; }

trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp

@@ -49 +49 @@
 WTF_MAKE_ISO_ALLOCATED_IMPL(MediaStream);
 
-static inline Ref<const Logger> loggerFromContext(ScriptExecutionContext& context)
-{
-    return downcast<Document>(context).logger();
-}
-
-Ref<MediaStream> MediaStream::create(ScriptExecutionContext& context)
-{
-    return MediaStream::create(context, MediaStreamPrivate::create(loggerFromContext(context), { }));
-}
-
-Ref<MediaStream> MediaStream::create(ScriptExecutionContext& context, MediaStream& stream)
-{
-    return adoptRef(*new MediaStream(context, stream.getTracks()));
-}
-
-Ref<MediaStream> MediaStream::create(ScriptExecutionContext& context, const MediaStreamTrackVector& tracks)
-{
-    return adoptRef(*new MediaStream(context, tracks));
-}
-
-Ref<MediaStream> MediaStream::create(ScriptExecutionContext& context, Ref<MediaStreamPrivate>&& streamPrivate)
-{
-    return adoptRef(*new MediaStream(context, WTFMove(streamPrivate)));
+Ref<MediaStream> MediaStream::create(Document& document)
+{
+    return MediaStream::create(document, MediaStreamPrivate::create(document.logger(), { }));
+}
+
+Ref<MediaStream> MediaStream::create(Document& document, MediaStream& stream)
+{
+    return adoptRef(*new MediaStream(document, stream.getTracks()));
+}
+
+Ref<MediaStream> MediaStream::create(Document& document, const MediaStreamTrackVector& tracks)
+{
+    return adoptRef(*new MediaStream(document, tracks));
+}
+
+Ref<MediaStream> MediaStream::create(Document& document, Ref<MediaStreamPrivate>&& streamPrivate)
+{
+    return adoptRef(*new MediaStream(document, WTFMove(streamPrivate)));
 }
 
@@ -83 +78 @@
 }
 
-MediaStream::MediaStream(ScriptExecutionContext& context, const MediaStreamTrackVector& tracks)
-    : ActiveDOMObject(&context)
-    , m_private(MediaStreamPrivate::create(document()->logger(), createTrackPrivateVector(tracks)))
+MediaStream::MediaStream(Document& document, const MediaStreamTrackVector& tracks)
+    : ActiveDOMObject(document)
+    , m_private(MediaStreamPrivate::create(document.logger(), createTrackPrivateVector(tracks)))
     , m_mediaSession(PlatformMediaSession::create(*this))
 {
@@ -102 +97 @@
 }
 
-MediaStream::MediaStream(ScriptExecutionContext& context, Ref<MediaStreamPrivate>&& streamPrivate)
-    : ActiveDOMObject(&context)
+MediaStream::MediaStream(Document& document, Ref<MediaStreamPrivate>&& streamPrivate)
+    : ActiveDOMObject(document)
     , m_private(WTFMove(streamPrivate))
     , m_mediaSession(PlatformMediaSession::create(*this))
@@ -114 +109 @@
 
     for (auto& trackPrivate : m_private->tracks()) {
-        auto track = MediaStreamTrack::create(context, *trackPrivate);
+        auto track = MediaStreamTrack::create(document, *trackPrivate);
         track->addObserver(*this);
         m_trackSet.add(track->id(), WTFMove(track));
@@ -146 +141 @@
         clonedTracks.uncheckedAppend(track->clone());
 
-    return MediaStream::create(*scriptExecutionContext(), clonedTracks);
+    return MediaStream::create(*document(), clonedTracks);
 }
 

trunk/Source/WebCore/Modules/mediastream/MediaStream.h

@@ -69 +69 @@
     };
 
-    static Ref<MediaStream> create(ScriptExecutionContext&);
-    static Ref<MediaStream> create(ScriptExecutionContext&, MediaStream&);
-    static Ref<MediaStream> create(ScriptExecutionContext&, const MediaStreamTrackVector&);
-    static Ref<MediaStream> create(ScriptExecutionContext&, Ref<MediaStreamPrivate>&&);
+    static Ref<MediaStream> create(Document&);
+    static Ref<MediaStream> create(Document&, MediaStream&);
+    static Ref<MediaStream> create(Document&, const MediaStreamTrackVector&);
+    static Ref<MediaStream> create(Document&, Ref<MediaStreamPrivate>&&);
     virtual ~MediaStream();
 
@@ -122 +122 @@
 
 protected:
-    MediaStream(ScriptExecutionContext&, const MediaStreamTrackVector&);
-    MediaStream(ScriptExecutionContext&, Ref<MediaStreamPrivate>&&);
+    MediaStream(Document&, const MediaStreamTrackVector&);
+    MediaStream(Document&, Ref<MediaStreamPrivate>&&);
 
 #if !RELEASE_LOG_DISABLED

trunk/Source/WebCore/Modules/mediastream/MediaStream.idl

@@ -29 +29 @@
     Constructor(MediaStream stream),
     Constructor(sequence<MediaStreamTrack> tracks),
-    ConstructorCallWith=ScriptExecutionContext,
+    ConstructorCallWith=Document,
     ExportToWrappedFunction,
     PrivateIdentifier,

trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp

@@ -234 +234 @@
         privateStream->monitorOrientation(downcast<Document>(m_scriptExecutionContext)->orientationNotifier());
 
-        auto stream = MediaStream::create(*m_scriptExecutionContext, privateStream.releaseNonNull());
+        auto stream = MediaStream::create(*downcast<Document>(m_scriptExecutionContext), privateStream.releaseNonNull());
         if (stream->getTracks().isEmpty()) {
             deny(MediaAccessDenialReason::HardwareError);

trunk/Source/WebCore/html/HTMLCanvasElement.cpp

@@ -786 +786 @@
 }
 
-ExceptionOr<Ref<MediaStream>> HTMLCanvasElement::captureStream(ScriptExecutionContext& context, Optional<double>&& frameRequestRate)
+ExceptionOr<Ref<MediaStream>> HTMLCanvasElement::captureStream(Document& document, Optional<double>&& frameRequestRate)
 {
     if (!originClean())
         return Exception(SecurityError, "Canvas is tainted"_s);
     if (RuntimeEnabledFeatures::sharedFeatures().webAPIStatisticsEnabled())
-        ResourceLoadObserver::shared().logCanvasRead(document());
+        ResourceLoadObserver::shared().logCanvasRead(this->document());
 
     if (frameRequestRate && frameRequestRate.value() < 0)
         return Exception(NotSupportedError, "frameRequestRate is negative"_s);
 
-    auto track = CanvasCaptureMediaStreamTrack::create(context, *this, WTFMove(frameRequestRate));
-    auto stream =  MediaStream::create(context);
+    auto track = CanvasCaptureMediaStreamTrack::create(document, *this, WTFMove(frameRequestRate));
+    auto stream =  MediaStream::create(document);
     stream->addTrack(track);
     return stream;

trunk/Source/WebCore/html/HTMLCanvasElement.h

@@ -122 +122 @@
 #if ENABLE(MEDIA_STREAM)
     RefPtr<MediaSample> toMediaSample();
-    ExceptionOr<Ref<MediaStream>> captureStream(ScriptExecutionContext&, Optional<double>&& frameRequestRate);
+    ExceptionOr<Ref<MediaStream>> captureStream(Document&, Optional<double>&& frameRequestRate);
 #endif
 

trunk/Source/WebCore/html/HTMLCanvasElement.idl

@@ -51 +51 @@
     [CallWith=ScriptExecutionContext, MayThrowException] void toBlob(BlobCallback callback, optional DOMString type, optional any quality);
 
-    [Conditional=MEDIA_STREAM, CallWith=ScriptExecutionContext, MayThrowException, NewObject] MediaStream captureStream(optional double frameRequestRate);
+    [Conditional=MEDIA_STREAM, CallWith=Document, MayThrowException, NewObject] MediaStream captureStream(optional double frameRequestRate);
 };