Changeset 246548 in webkit

Timestamp:

Jun 18, 2019 10:20:10 AM (5 years ago)

Author:

david_quesada@apple.com

Message:

REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
​https://bugs.webkit.org/show_bug.cgi?id=198954
rdar://problem/51711556

Reviewed by Alex Christensen.

For these tests, kill the web process after the download starts. This makes the deallocation
of the download-originating web views, which these tests depend on, more reliable.

• TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
(-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/Download.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-18  David Quesada  <david_quesada@apple.com>
+
+        REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
+        https://bugs.webkit.org/show_bug.cgi?id=198954
+        rdar://problem/51711556
+
+        Reviewed by Alex Christensen.
+
+        For these tests, kill the web process after the download starts. This makes the deallocation
+        of the download-originating web views, which these tests depend on, more reliable.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
+        (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
+        (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
+
 2019-06-18  Dan Bernstein  <mitz@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm

@@ -260 +260 @@
 {
     EXPECT_EQ([download originatingWebView], _webView);
+    [_webView _killWebContentProcessAndResetState];
     _webView = nullptr;
 
@@ -751 +752 @@
 {
     didDownloadStart = true;
+    [download.originatingWebView _killWebContentProcessAndResetState];
 }