Changeset 246620 in webkit

Timestamp:

Jun 19, 2019 5:38:20 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Optimize resolve method lookup in Promise static methods
​https://bugs.webkit.org/show_bug.cgi?id=198864

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-06-19
Reviewed by Yusuke Suzuki.

JSTests:

• test262/expectations.yaml: Mark 18 test cases as passing.

Source/JavaScriptCore:

Lookup resolve method only once in Promise.{all,allSettled,race}.
(​https://github.com/tc39/ecma262/pull/1506)

Already implemented in V8.

• builtins/PromiseConstructor.js:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/test262/expectations.yaml (modified) (2 diffs)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/builtins/PromiseConstructor.js (modified) (3 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-06-19  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Optimize `resolve` method lookup in Promise static methods
+        https://bugs.webkit.org/show_bug.cgi?id=198864
+
+        Reviewed by Yusuke Suzuki.
+
+        * test262/expectations.yaml: Mark 18 test cases as passing.
+
 2019-06-19  Justin Michaud  <justin_michaud@apple.com>
 

trunk/JSTests/test262/expectations.yaml

@@ -1096 +1096 @@
   default: 'Test262Error: Expected SameValue(«undefined», «1») to be true'
   strict mode: 'Test262Error: Expected SameValue(«undefined», «1») to be true'
-test/built-ins/Promise/all/invoke-resolve-get-error-close.js:
-  default: 'Test262Error: Expected SameValue(«1», «0») to be true'
-  strict mode: 'Test262Error: Expected SameValue(«1», «0») to be true'
-test/built-ins/Promise/all/invoke-resolve-get-once-multiple-calls.js:
-  default: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«4», «1») to be true'
-  strict mode: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«4», «1») to be true'
-test/built-ins/Promise/all/invoke-resolve-get-once-no-calls.js:
-  default: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«0», «1») to be true'
-  strict mode: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«0», «1») to be true'
 test/built-ins/Promise/all/resolve-element-function-nonconstructor.js:
   default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
   strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
-test/built-ins/Promise/allSettled/invoke-resolve-get-error-close.js:
-  default: 'Test262Error: Expected SameValue(«1», «0») to be true'
-  strict mode: 'Test262Error: Expected SameValue(«1», «0») to be true'
-test/built-ins/Promise/allSettled/invoke-resolve-get-once-multiple-calls.js:
-  default: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«4», «1») to be true'
-  strict mode: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«4», «1») to be true'
-test/built-ins/Promise/allSettled/invoke-resolve-get-once-no-calls.js:
-  default: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«0», «1») to be true'
-  strict mode: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«0», «1») to be true'
 test/built-ins/Promise/allSettled/reject-element-function-nonconstructor.js:
   default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
@@ -1129 +1111 @@
   default: 'Test262Error: Expected SameValue(«[object Promise]», «[object Promise]») to be true'
   strict mode: 'Test262Error: Expected SameValue(«[object Promise]», «[object Promise]») to be true'
-test/built-ins/Promise/race/invoke-resolve-get-error-close.js:
-  default: 'Test262Error: Expected SameValue(«1», «0») to be true'
-  strict mode: 'Test262Error: Expected SameValue(«1», «0») to be true'
-test/built-ins/Promise/race/invoke-resolve-get-once-multiple-calls.js:
-  default: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«4», «1») to be true'
-  strict mode: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«4», «1») to be true'
-test/built-ins/Promise/race/invoke-resolve-get-once-no-calls.js:
-  default: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«0», «1») to be true'
-  strict mode: 'Test262Error: Got `resolve` only once for each iterated value Expected SameValue(«0», «1») to be true'
 test/built-ins/Promise/reject-function-nonconstructor.js:
   default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-06-19  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Optimize `resolve` method lookup in Promise static methods
+        https://bugs.webkit.org/show_bug.cgi?id=198864
+
+        Reviewed by Yusuke Suzuki.
+
+        Lookup `resolve` method only once in Promise.{all,allSettled,race}.
+        (https://github.com/tc39/ecma262/pull/1506)
+
+        Already implemented in V8.
+
+        * builtins/PromiseConstructor.js:
+
 2019-06-19  Tadeu Zagallo  <tzagallo@apple.com>
 

trunk/Source/JavaScriptCore/builtins/PromiseConstructor.js

@@ -57 +57 @@
 
     try {
+        var promiseResolve = this.resolve;
+        if (typeof promiseResolve !== "function")
+            @throwTypeError("Promise resolve is not a function");
+
         for (var value of iterable) {
             @putByValDirect(values, index, @undefined);
-            var nextPromise = this.resolve(value);
+            var nextPromise = promiseResolve.@call(this, value);
             var resolveElement = newResolveElement(index);
             ++remainingElementsCount;
@@ -137 +141 @@
 
     try {
+        var promiseResolve = this.resolve;
+        if (typeof promiseResolve !== "function")
+            @throwTypeError("Promise resolve is not a function");
+
         for (var value of iterable) {
             @putByValDirect(values, index, @undefined);
-            var nextPromise = this.resolve(value);
+            var nextPromise = promiseResolve.@call(this, value);
             var [resolveElement, rejectElement] = newResolveRejectElements(index);
             ++remainingElementsCount;
@@ -166 +174 @@
 
     try {
+        var promiseResolve = this.resolve;
+        if (typeof promiseResolve !== "function")
+            @throwTypeError("Promise resolve is not a function");
+
         for (var value of iterable) {
-            var nextPromise = this.resolve(value);
+            var nextPromise = promiseResolve.@call(this, value);
             nextPromise.then(promiseCapability.@resolve, promiseCapability.@reject);
         }