Changeset 246659 in webkit
- Timestamp:
- Jun 20, 2019 3:52:03 PM (5 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r246658 r246659 1 2019-06-20 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Debugger: setting a breakpoint on a non-JavaScript line should immediately show as unresolved 4 https://bugs.webkit.org/show_bug.cgi?id=199033 5 6 Reviewed by Matt Baker. 7 8 Remove the `shouldSpeculativelyResolve` parameter, as it was resolving breakpoints even in 9 the case that there were no resolved locations for the given breakpoint. 10 11 In the case that there are resolved locations, the breakpoint would've already been resolved 12 by the time that `shouldSpeculativelyResolve` would've taken effect, so it's unnecessary. 13 14 This parameter was only used when setting a breakpoint from a `SourceCodeTextEditor` gutter. 15 16 * UserInterface/Controllers/DebuggerManager.js: 17 (WI.DebuggerManager.prototype.addBreakpoint): 18 (WI.DebuggerManager.prototype._setBreakpoint): 19 (WI.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint): 20 21 * UserInterface/Views/SourceCodeTextEditor.js: 22 (WI.SourceCodeTextEditor.prototype.textEditorBreakpointAdded): 23 1 24 2019-06-20 Devin Rousso <drousso@apple.com> 2 25 -
trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
r244398 r246659 472 472 } 473 473 474 addBreakpoint(breakpoint , shouldSpeculativelyResolve)474 addBreakpoint(breakpoint) 475 475 { 476 476 console.assert(breakpoint instanceof WI.Breakpoint); … … 493 493 if (!breakpoint.disabled) { 494 494 const specificTarget = undefined; 495 this._setBreakpoint(breakpoint, specificTarget, () => { 496 if (shouldSpeculativelyResolve) 497 breakpoint.resolved = true; 498 }); 495 this._setBreakpoint(breakpoint, specificTarget); 499 496 } 500 497 … … 934 931 } 935 932 936 _setBreakpoint(breakpoint, specificTarget , callback)933 _setBreakpoint(breakpoint, specificTarget) 937 934 { 938 935 console.assert(!breakpoint.disabled); … … 963 960 for (let location of locations) 964 961 this.breakpointResolved(target, breakpointIdentifier, location); 965 966 if (typeof callback === "function")967 callback();968 962 } 969 963 -
trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
r246502 r246659 1298 1298 1299 1299 this._ignoreBreakpointAddedBreakpoint = breakpoint; 1300 const shouldSpeculativelyResolveBreakpoint = true; 1301 WI.debuggerManager.addBreakpoint(breakpoint, shouldSpeculativelyResolveBreakpoint); 1300 WI.debuggerManager.addBreakpoint(breakpoint); 1302 1301 this._ignoreBreakpointAddedBreakpoint = null; 1303 1302
Note: See TracChangeset
for help on using the changeset viewer.