Changeset 246683 in webkit

Timestamp:

Jun 21, 2019 10:45:01 AM (5 years ago)

Author:

Truitt Savell

Message:

Unreviewed, rolling out r246655.

Introduced a failing test

Reverted changeset:

"Web Inspector: AXI: Audit: image label test is throwing
spurious errors on elements with existing alt attr, but no
value: <img alt>"
​https://bugs.webkit.org/show_bug.cgi?id=194754
​https://trac.webkit.org/changeset/246655

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/img-alt-attribute-unassigned-value-expected.txt (deleted)
• LayoutTests/accessibility/img-alt-attribute-unassigned-value.html (deleted)
• LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt (modified) (10 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-21  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r246655.
+
+        Introduced a failing test
+
+        Reverted changeset:
+
+        "Web Inspector: AXI: Audit: image label test is throwing
+        spurious errors on elements with existing alt attr, but no
+        value: <img alt>"
+        https://bugs.webkit.org/show_bug.cgi?id=194754
+        https://trac.webkit.org/changeset/246655
+
 2019-06-21  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt

@@ -327 +327 @@
     exists: true
     label: x
-    role: presentation
+    role: img
     ignored: true
     ignoredByDefault: true
@@ -340 +340 @@
     exists: true
     label: 
-    role: presentation
+    role: img
     ignored: true
 
@@ -351 +351 @@
     exists: true
     label: 
-    role: presentation
+    role: img
     ignored: true
 
@@ -362 +362 @@
     exists: true
     label: 
-    role: presentation
+    role: 
     focused: false
     ignored: true
@@ -907 +907 @@
     exists: true
     label: 
-    role: presentation
+    role: 
     ignored: true
     ignoredByDefault: true
@@ -916 +916 @@
     exists: true
     label: 
-    role: presentation
+    role: 
     ignored: true
     ignoredByDefault: true
@@ -924 +924 @@
     exists: true
     label: 
-    role: presentation
+    role: 
     ignored: true
     ignoredByDefault: true
@@ -933 +933 @@
     exists: true
     label: 
-    role: presentation
+    role: 
     ignored: true
     parentNodeId: exists
@@ -962 +962 @@
     exists: true
     label: 
-    role: presentation
+    role: 
     ignored: true
     parentNodeId: exists
@@ -969 +969 @@
     exists: true
     label: 
-    role: presentation
+    role: 
     ignored: true
     parentNodeId: exists

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-21  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r246655.
+
+        Introduced a failing test
+
+        Reverted changeset:
+
+        "Web Inspector: AXI: Audit: image label test is throwing
+        spurious errors on elements with existing alt attr, but no
+        value: <img alt>"
+        https://bugs.webkit.org/show_bug.cgi?id=194754
+        https://trac.webkit.org/changeset/246655
+
 2019-06-21  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -2494 +2494 @@
     AccessibilityRole role = roleValue();
 
-    if (role == AccessibilityRole::Image && accessibilityIsIgnored())
-        return reverseAriaRoleMap().get(static_cast<int>(AccessibilityRole::Presentational));
-
     // We do not compute a role string for generic block elements with user-agent assigned roles.
     if (role == AccessibilityRole::Group || role == AccessibilityRole::TextGroup)