Changeset 246692 in webkit

Timestamp:

Jun 21, 2019 1:28:05 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Remove extra check in RegExp @matchSlow
​https://bugs.webkit.org/show_bug.cgi?id=198846

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-06-21
Reviewed by Joseph Pecoraro.

Type of RegExp exec result is already asserted in @regExpExec.

• builtins/RegExpPrototype.js:

(globalPrivate.matchSlow): Remove isObject check.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• builtins/RegExpPrototype.js (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-06-21  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Remove extra check in RegExp @matchSlow
+        https://bugs.webkit.org/show_bug.cgi?id=198846
+
+        Reviewed by Joseph Pecoraro.
+
+        Type of RegExp `exec` result is already asserted in @regExpExec.
+
+        * builtins/RegExpPrototype.js:
+        (globalPrivate.matchSlow): Remove isObject check.
+
 2019-06-20  Justin Michaud  <justin_michaud@apple.com>
 

trunk/Source/JavaScriptCore/builtins/RegExpPrototype.js

@@ -127 +127 @@
         if (resultList.length > maximumReasonableMatchSize)
             @throwOutOfMemoryError();
-
-        if (!@isObject(result))
-            @throwTypeError("RegExp.prototype.@@match call to RegExp.exec didn't return null or an object");
 
         let resultString = @toString(result[0]);