Changeset 246731 in webkit


Ignore:
Timestamp:
Jun 24, 2019 4:33:30 AM (5 years ago)
Author:
cturner@igalia.com
Message:

[GStreamer][MSE] Pausing video sometimes causes skip to finish
https://bugs.webkit.org/show_bug.cgi?id=197355

Reviewed by Philippe Normand.

Covered by existing tests.

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
Assuming that when m_eosPending is on and we're paused() that the
network resource is fully loaded and the end is reached is clearly
wrong. Whether this is now correct is unclear...

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r246730 r246731  
     12019-06-24  Charlie Turner  <cturner@igalia.com>
     2
     3        [GStreamer][MSE] Pausing video sometimes causes skip to finish
     4        https://bugs.webkit.org/show_bug.cgi?id=197355
     5
     6        Reviewed by Philippe Normand.
     7
     8        Covered by existing tests.
     9
     10        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
     11        (WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
     12        Assuming that when m_eosPending is on and we're paused() that the
     13        network resource is fully loaded and the end is reached is clearly
     14        wrong. Whether this is now correct is unclear...
     15
    1162019-06-24  Charlie Turner  <cturner@igalia.com>
    217
  • trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

    r246490 r246731  
    759759    MediaTime position = MediaPlayerPrivateGStreamer::currentMediaTime();
    760760
    761     if (m_eosPending && (paused() || (position >= durationMediaTime()))) {
     761    if (m_eosPending && position >= durationMediaTime()) {
    762762        if (m_networkState != MediaPlayer::Loaded) {
    763763            m_networkState = MediaPlayer::Loaded;
Note: See TracChangeset for help on using the changeset viewer.