Changeset 246733 in webkit

Timestamp:

Jun 24, 2019 7:35:42 AM (5 years ago)

Author:

Michael Catanzaro

Message:

Add user agent quirk for Google Drive
​https://bugs.webkit.org/show_bug.cgi?id=199153

Reviewed by Carlos Garcia Campos.

Source/WebCore:

This suppresses an unsupported browser warning.

• platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresMacintoshPlatform):
(WebCore::urlRequiresLinuxDesktopPlatform):

Tools:

• TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/UserAgentQuirks.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Add user agent quirk for Google Drive
+        https://bugs.webkit.org/show_bug.cgi?id=199153
+
+        Reviewed by Carlos Garcia Campos.
+
+        This suppresses an unsupported browser warning.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::urlRequiresMacintoshPlatform):
+        (WebCore::urlRequiresLinuxDesktopPlatform):
+
 2019-06-24  Charlie Turner  <cturner@igalia.com>
 

trunk/Source/WebCore/platform/UserAgentQuirks.cpp

@@ -105 +105 @@
         return true;
 
-    // Google Docs shows a scary unsupported browser warning with WebKitGTK+'s
-    // standard user agent.
-    if (domain == "docs.google.com")
+    // Google Docs and Google Drive both show a scary unsupported browser
+    // warning with WebKitGTK+'s standard user agent.
+    if (domain == "docs.google.com"
+        || domain == "drive.google.com")
         return true;
 
@@ -115 +116 @@
 static bool urlRequiresLinuxDesktopPlatform(const URL& url)
 {
-    // docs.google.com requires the macOS platform quirk.
-    return isGoogle(url) && url.host() != "docs.google.com";
+    // docs.google.com and drive.google.com require the macOS platform quirk.
+    return isGoogle(url)
+        && url.host() != "docs.google.com"
+        && url.host() != "drive.google.com";
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Add user agent quirk for Google Drive
+        https://bugs.webkit.org/show_bug.cgi?id=199153
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+        (TestWebKitAPI::TEST):
+
 2019-06-22  Zalan Bujtas  <zalan@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp

@@ -94 +94 @@
     assertUserAgentForURLHasMacPlatformQuirk("http://www.chase.com/");
     assertUserAgentForURLHasMacPlatformQuirk("http://docs.google.com/");
+    assertUserAgentForURLHasMacPlatformQuirk("http://drive.google.com/");
     assertUserAgentForURLHasMacPlatformQuirk("http://paypal.com/");
     assertUserAgentForURLHasMacPlatformQuirk("http://outlook.live.com/");