Changeset 246743 in webkit

Timestamp:

Jun 24, 2019 11:20:43 AM (5 years ago)

Author:

dean_johnson@apple.com

Message:

[perf.webkit.org] Update summary page calculations to use mean instead of median
​https://bugs.webkit.org/show_bug.cgi?id=199050

Reviewed by Dewei Zhu.

• public/v3/pages/summary-page.js:

(SummaryPageConfigurationGroup): Updated 'median' references to 'mean'.
(SummaryPageConfigurationGroup.set _startAndEndPointForTimeRange): Factored out logic for finding data
points in a timeSeries, within a specified timeRange.
(SummaryPageConfigurationGroup.set _meanForTimeRange): New. Returns the mean of a timeSeries across a
given timeRange.

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/v3/pages/summary-page.js (modified) (3 diffs)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2019-06-24  Dean Johnson  <dean_johnson@apple.com>
+
+        [perf.webkit.org] Update summary page calculations to use mean instead of median
+        https://bugs.webkit.org/show_bug.cgi?id=199050
+
+        Reviewed by Dewei Zhu.
+
+        * public/v3/pages/summary-page.js:
+        (SummaryPageConfigurationGroup): Updated 'median' references to 'mean'.
+        (SummaryPageConfigurationGroup.set _startAndEndPointForTimeRange): Factored out logic for finding data
+        points in a timeSeries, within a specified timeRange.
+        (SummaryPageConfigurationGroup.set _meanForTimeRange): New. Returns the mean of a timeSeries across a
+        given timeRange.
+
 2019-06-20  Dewei Zhu  <dewei_zhu@apple.com>
 

trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js

@@ -347 +347 @@
             var currentTimeSeries = set.fetchedTimeSeries('current', false, false);
 
-            var baselineMedian = SummaryPageConfigurationGroup._medianForTimeRange(baselineTimeSeries, timeRange);
-            var currentMedian = SummaryPageConfigurationGroup._medianForTimeRange(currentTimeSeries, timeRange);
+            const baselineMean = SummaryPageConfigurationGroup._meanForTimeRange(baselineTimeSeries, timeRange);
+            const currentMean = SummaryPageConfigurationGroup._meanForTimeRange(currentTimeSeries, timeRange);
             var platform = Platform.findById(set.platformId());
-            if (!currentMedian)
+            if (!currentMean)
                 self._missingPlatforms.add(platform);
-            else if (!baselineMedian)
+            else if (!baselineMean)
                 self._platformsWithoutBaseline.add(platform);
 
-            setToRatio.set(set, currentMedian / baselineMedian);
+            setToRatio.set(set, currentMean / baselineMean);
         }).catch(function () {
             setToRatio.set(set, NaN);
@@ -361 +361 @@
     }
 
-    static _medianForTimeRange(timeSeries, timeRange)
+    static _startAndEndPointForTimeRange(timeSeries, timeRange)
     {
         if (!timeSeries.firstPoint())
@@ -372 +372 @@
             endPoint = afterEndPoint;
 
-        return Statistics.median(timeSeries.viewBetweenPoints(startPoint, endPoint).values());
+        return [startPoint, endPoint];
+    }
+
+    static _meanForTimeRange(timeSeries, timeRange)
+    {
+        const [startPoint, endPoint] = SummaryPageConfigurationGroup._startAndEndPointForTimeRange(timeSeries, timeRange);
+        return Statistics.mean(timeSeries.viewBetweenPoints(startPoint, endPoint).values());
     }
 }