Changeset 246763 in webkit


Ignore:
Timestamp:
Jun 24, 2019 2:37:26 PM (5 years ago)
Author:
wilander@apple.com
Message:

Remove IsITPFirstPartyWebsiteDataRemovalEnabled as runtime check
​https://bugs.webkit.org/show_bug.cgi?id=199164
<rdar://problem/52061147>

Reviewed by Brent Fulgham.

Source/WebCore:

No new tests. Just a removal of a runtime feature check. The functionality
already has a layout test.

We've had this toggle as a safety thing since mid-March. No need for it any longer.

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::isITPDatabaseEnabled const):
(WebCore::RuntimeEnabledFeatures::setIsITPFirstPartyWebsiteDataRemovalEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::isITPFirstPartyWebsiteDataRemovalEnabled const): Deleted.

Source/WebKit:

We've had this toggle as a safety thing since mid-March. No need for it any longer.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::shouldRemoveAllButCookiesFor const):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • Shared/WebPreferences.yaml:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

Location:
trunk/Source
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r246759 r246763  
     12019-06-24  John Wilander  <wilander@apple.com>
     2
     3        Remove IsITPFirstPartyWebsiteDataRemovalEnabled as runtime check
     4        https://bugs.webkit.org/show_bug.cgi?id=199164
     5        <rdar://problem/52061147>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        No new tests. Just a removal of a runtime feature check. The functionality
     10        already has a layout test.
     11
     12        We've had this toggle as a safety thing since mid-March. No need for it any longer.
     13
     14        * page/RuntimeEnabledFeatures.h:
     15        (WebCore::RuntimeEnabledFeatures::isITPDatabaseEnabled const):
     16        (WebCore::RuntimeEnabledFeatures::setIsITPFirstPartyWebsiteDataRemovalEnabled): Deleted.
     17        (WebCore::RuntimeEnabledFeatures::isITPFirstPartyWebsiteDataRemovalEnabled const): Deleted.
     18
    1192019-06-24  Jer Noble  <jer.noble@apple.com>
    220

  • trunk/Source/WebCore/page/RuntimeEnabledFeatures.h

    r246596 r246763  
    152152    void setIsITPDatabaseEnabled(bool isEnabled) { m_isITPDatabaseEnabled = isEnabled; }
    153153    bool isITPDatabaseEnabled() const { return m_isITPDatabaseEnabled; }
    154    
    155     void setIsITPFirstPartyWebsiteDataRemovalEnabled(bool isEnabled) { m_isITPFirstPartyWebsiteDataRemovalEnabled = isEnabled; }
    156     bool isITPFirstPartyWebsiteDataRemovalEnabled() const { return m_isITPFirstPartyWebsiteDataRemovalEnabled; }
    157154
    158155    void setRestrictedHTTPResponseAccess(bool isEnabled) { m_isRestrictedHTTPResponseAccess = isEnabled; }
    … …  
    554551
    555552    bool m_isITPDatabaseEnabled { false };
    556     bool m_isITPFirstPartyWebsiteDataRemovalEnabled { false };
    557553
    558554    bool m_referrerPolicyAttributeEnabled { false };

  • trunk/Source/WebKit/ChangeLog

    r246757 r246763  
     12019-06-24  John Wilander  <wilander@apple.com>
     2
     3        Remove IsITPFirstPartyWebsiteDataRemovalEnabled as runtime check
     4        https://bugs.webkit.org/show_bug.cgi?id=199164
     5        <rdar://problem/52061147>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        We've had this toggle as a safety thing since mid-March. No need for it any longer.
     10
     11        * NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
     12        (WebKit::ResourceLoadStatisticsMemoryStore::shouldRemoveAllButCookiesFor const):
     13        * NetworkProcess/NetworkProcess.cpp:
     14        (WebKit::NetworkProcess::initializeNetworkProcess):
     15        * NetworkProcess/NetworkProcessCreationParameters.cpp:
     16        (WebKit::NetworkProcessCreationParameters::encode const):
     17        (WebKit::NetworkProcessCreationParameters::decode):
     18        * NetworkProcess/NetworkProcessCreationParameters.h:
     19        * Shared/WebPreferences.yaml:
     20        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
     21        (WebKit::WebProcessPool::platformInitializeNetworkProcess):
     22
    1232019-06-24  Daniel Bates  <dabates@apple.com>
    224

  • trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp

    r246561 r246763  
    4242#include <WebCore/NetworkStorageSession.h>
    4343#include <WebCore/ResourceLoadStatistics.h>
    44 #include <WebCore/RuntimeEnabledFeatures.h>
    4544#include <WebCore/UserGestureIndicator.h>
    4645#include <wtf/CallbackAggregator.h>
    … …  
    798797bool ResourceLoadStatisticsMemoryStore::shouldRemoveAllButCookiesFor(ResourceLoadStatistics& resourceStatistic, bool shouldCheckForGrandfathering) const
    799798{
    800     return RuntimeEnabledFeatures::sharedFeatures().isITPFirstPartyWebsiteDataRemovalEnabled() && resourceStatistic.gotLinkDecorationFromPrevalentResource && !hasHadUnexpiredRecentUserInteraction(resourceStatistic, OperatingDatesWindow::Short) && (!shouldCheckForGrandfathering || !resourceStatistic.grandfathered);
     799    return resourceStatistic.gotLinkDecorationFromPrevalentResource && !hasHadUnexpiredRecentUserInteraction(resourceStatistic, OperatingDatesWindow::Short) && (!shouldCheckForGrandfathering || !resourceStatistic.grandfathered);
    801800}
    802801

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp

    r246569 r246763  
    310310
    311311    WebCore::RuntimeEnabledFeatures::sharedFeatures().setIsITPDatabaseEnabled(parameters.shouldEnableITPDatabase);
    312     WebCore::RuntimeEnabledFeatures::sharedFeatures().setIsITPFirstPartyWebsiteDataRemovalEnabled(parameters.isITPFirstPartyWebsiteDataRemovalEnabled);
    313312
    314313    WebCore::RuntimeEnabledFeatures::sharedFeatures().setAdClickAttributionDebugModeEnabled(parameters.enableAdClickAttributionDebugMode);

  • trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp

    r245075 r246763  
    9191    encoder << shouldEnableITPDatabase;
    9292    encoder << downloadMonitorSpeedMultiplier;
    93     encoder << isITPFirstPartyWebsiteDataRemovalEnabled;
    9493    encoder << enableAdClickAttributionDebugMode;
    9594    encoder << hstsStorageDirectory;
    … …  
    221220    result.downloadMonitorSpeedMultiplier = *downloadMonitorSpeedMultiplier;
    222221
    223     if (!decoder.decode(result.isITPFirstPartyWebsiteDataRemovalEnabled))
    224         return false;
    225 
    226222    if (!decoder.decode(result.enableAdClickAttributionDebugMode))
    227223        return false;

  • trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h

    r245075 r246763  
    108108#endif
    109109    bool shouldEnableITPDatabase { false };
    110     bool isITPFirstPartyWebsiteDataRemovalEnabled { true };
    111110    uint32_t downloadMonitorSpeedMultiplier { 1 };
    112111    bool enableAdClickAttributionDebugMode { false };

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r246444 r246763  
    13941394  category: experimental
    13951395
    1396 IsITPFirstPartyWebsiteDataRemovalEnabled:
    1397     type: bool
    1398     defaultValue: true
    1399     humanReadableName: "ITP First Party Website Data Removal"
    1400     humanReadableDescription: "Enable Intelligent Tracking Prevention First Party Website Data Removal"
    1401     webcoreBinding: RuntimeEnabledFeatures
    1402     category: experimental
    1403 
    14041396ResizeObserverEnabled:
    14051397  type: bool

  • trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

    r244955 r246763  
    300300    parameters.downloadMonitorSpeedMultiplier = m_configuration->downloadMonitorSpeedMultiplier();
    301301
    302     // Check if the feature has been turned off explicitly. This avoids interpreting
    303     // a non-existing default as a false value.
    304     auto isITPFirstPartyWebsiteDataRemovalEnabledStr = [defaults stringForKey:[NSString stringWithFormat:@"Experimental%@", WebPreferencesKey::isITPFirstPartyWebsiteDataRemovalEnabledKey().createCFString().get()]];
    305     if ([isITPFirstPartyWebsiteDataRemovalEnabledStr isEqual:@"0"])
    306         parameters.isITPFirstPartyWebsiteDataRemovalEnabled = false;
    307 
    308302    parameters.enableAdClickAttributionDebugMode = [defaults boolForKey:[NSString stringWithFormat:@"Experimental%@", WebPreferencesKey::adClickAttributionDebugModeEnabledKey().createCFString().get()]];
    309303}
Note: See TracChangeset for help on using the changeset viewer.