Changeset 246768 in webkit

Timestamp:

Jun 24, 2019 4:26:36 PM (5 years ago)

Author:

sihui_liu@apple.com

Message:

Remove WebSQL quirk for nytimes.com
​https://bugs.webkit.org/show_bug.cgi?id=199175

Reviewed by Geoffrey Garen.

Removed unused code.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateRuntimeEnableConditionalString):

• bindings/scripts/IDLAttributes.json:
• page/Quirks.cpp:

(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
(WebCore::Quirks::hasWebSQLSupportQuirk const): Deleted.

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (1 diff)
• bindings/scripts/IDLAttributes.json (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-24  Sihui Liu  <sihui_liu@apple.com>
+
+        Remove WebSQL quirk for nytimes.com
+        https://bugs.webkit.org/show_bug.cgi?id=199175
+
+        Reviewed by Geoffrey Garen.
+
+        Removed unused code.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateRuntimeEnableConditionalString):
+        * bindings/scripts/IDLAttributes.json:
+        * page/Quirks.cpp:
+        (WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
+        (WebCore::Quirks::hasWebSQLSupportQuirk const): Deleted.
+        * page/Quirks.h:
+
 2019-06-24  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -3773 +3773 @@
         AddToImplIncludes("RuntimeEnabledFeatures.h");
 
-        if ($context->extendedAttributes->{EnabledByQuirk}) {
-            AddToImplIncludes("Document.h");
-            AddToImplIncludes("Quirks.h");
-            
-            assert("EnabledByQuirks can only be used by interfaces only exposed to the Window") if $interface->extendedAttributes->{Exposed} && $interface->extendedAttributes->{Exposed} ne "Window";
-    
-            my @quirkFlags = split(/&/, $context->extendedAttributes->{EnabledByQuirk});
-            my @runtimeFlags = split(/&/, $context->extendedAttributes->{EnabledAtRuntime});
-            my @quirks;
-            my @runtimes;
-            foreach my $flag (@quirkFlags) {
-                push(@quirks, "downcast<Document>(jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext())->quirks()." . ToMethodName($flag) . "Quirk()");
-            }
-            foreach my $flag (@runtimeFlags) {
-                push(@runtimes, "RuntimeEnabledFeatures::sharedFeatures()." . ToMethodName($flag) . "Enabled()");
-            }
-            push(@conjuncts, "(" . join(" && ", @quirks) . " || " . join(" && ", @runtimes) .")");
-        } else {
-            my @flags = split(/&/, $context->extendedAttributes->{EnabledAtRuntime});
-            foreach my $flag (@flags) {
-                push(@conjuncts, "RuntimeEnabledFeatures::sharedFeatures()." . ToMethodName($flag) . "Enabled()");
-            }
+        my @flags = split(/&/, $context->extendedAttributes->{EnabledAtRuntime});
+        foreach my $flag (@flags) {
+            push(@conjuncts, "RuntimeEnabledFeatures::sharedFeatures()." . ToMethodName($flag) . "Enabled()");
         }
     }

trunk/Source/WebCore/bindings/scripts/IDLAttributes.json

@@ -192 +192 @@
             "values": ["*"]
         },
-        "EnabledByQuirk": {
-            "contextsAllowed": ["interface", "dictionary", "enum", "attribute", "operation", "constant"],
-            "values": ["*"]
-        },
         "EnabledForContext": {
             "contextsAllowed": ["attribute", "interface"]

trunk/Source/WebCore/page/Quirks.cpp

@@ -170 +170 @@
 }
 
-bool Quirks::hasWebSQLSupportQuirk() const
-{
-    if (!needsQuirks())
-        return false;
-    
-    if (m_hasWebSQLSupportQuirk)
-        return m_hasWebSQLSupportQuirk.value();
-    
-    auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
-    
-    m_hasWebSQLSupportQuirk = domain == "bostonglobe.com"
-        || domain.endsWith(".bostonglobe.com")
-        || domain == "latimes.com"
-        || domain.endsWith(".latimes.com")
-        || domain == "washingtonpost.com"
-        || domain.endsWith(".washingtonpost.com")
-        || domain == "nytimes.com"
-        || domain.endsWith(".nytimes.com");
-    
-    return m_hasWebSQLSupportQuirk.value();
-}
-
 bool Quirks::isTouchBarUpdateSupressedForHiddenContentEditable() const
 {

trunk/Source/WebCore/page/Quirks.h

@@ -50 +50 @@
     bool shouldAutoplayForArbitraryUserGesture() const;
     bool hasBrokenEncryptedMediaAPISupportQuirk() const;
-    bool hasWebSQLSupportQuirk() const;
 #if ENABLE(TOUCH_EVENTS)
     bool shouldDispatchSimulatedMouseEvents() const;
@@ -72 +71 @@
 
     mutable Optional<bool> m_hasBrokenEncryptedMediaAPISupportQuirk;
-    mutable Optional<bool> m_hasWebSQLSupportQuirk;
 #if PLATFORM(IOS_FAMILY)
     mutable Optional<bool> m_needsGMailOverflowScrollQuirk;