Changeset 246795 in webkit

Timestamp:

Jun 25, 2019 10:29:53 AM (5 years ago)

Author:

timothy_horton@apple.com

Message:

When Caps Lock is enabled on the Smart Keyboard, can't scroll with space or arrow keys
​https://bugs.webkit.org/show_bug.cgi?id=199187
<rdar://problem/51521709>

Reviewed by Anders Carlsson.

• UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]):
When deciding whether a key event should start a scroll, ignore all
modifiers other than the ones we actually care about (including Caps Lock).

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKKeyboardScrollingAnimator.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-25  Tim Horton  <timothy_horton@apple.com>
+
+        When Caps Lock is enabled on the Smart Keyboard, can't scroll with space or arrow keys
+        https://bugs.webkit.org/show_bug.cgi?id=199187
+        <rdar://problem/51521709>
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
+        (-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]):
+        When deciding whether a key event should start a scroll, ignore all
+        modifiers other than the ones we actually care about (including Caps Lock).
+
 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm

@@ -244 +244 @@
     }();
 
-    if (event.modifierFlags & ~allowedModifiers)
+    auto relevantModifierFlags = WebEventFlagMaskOptionKey | WebEventFlagMaskCommandKey | WebEventFlagMaskShiftKey;
+    if (event.modifierFlags & relevantModifierFlags & ~allowedModifiers)
         return WTF::nullopt;