Changeset 246818 in webkit

Timestamp:

Jun 25, 2019 4:42:03 PM (5 years ago)

Author:

timothy@apple.com

Message:

Clicking the up/down spin buttons for a number input increments/decrements by 2.
​https://bugs.webkit.org/show_bug.cgi?id=198809

Reviewed by Tim Horton.

AppKit no longer registers NSScrollerButtonDelay and NSScrollerButtonPeriod in the base
NSUserDefaults for an app. This caused our use to always get 0s when setting the click
and hold timer, causing the value to increment quickly for a single press.

• platform/mac/ScrollbarThemeMac.h:

(WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay): Added. Hardcode 500ms.
(WebCore::ScrollbarThemeMac::autoscrollTimerDelay): Added. Hardcode 50ms.

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::preferencesChanged): Removed use of old user defaults.
(WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay): Deleted.
(WebCore::ScrollbarThemeMac::autoscrollTimerDelay): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/ScrollbarThemeMac.h (modified) (1 diff)
• platform/mac/ScrollbarThemeMac.mm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-25  Timothy Hatcher  <timothy@apple.com>
+
+        Clicking the up/down spin buttons for a number input increments/decrements by 2.
+        https://bugs.webkit.org/show_bug.cgi?id=198809
+
+        Reviewed by Tim Horton.
+
+        AppKit no longer registers NSScrollerButtonDelay and NSScrollerButtonPeriod in the base
+        NSUserDefaults for an app. This caused our use to always get 0s when setting the click
+        and hold timer, causing the value to increment quickly for a single press.
+
+        * platform/mac/ScrollbarThemeMac.h:
+        (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay): Added. Hardcode 500ms.
+        (WebCore::ScrollbarThemeMac::autoscrollTimerDelay): Added. Hardcode 50ms.
+        * platform/mac/ScrollbarThemeMac.mm:
+        (WebCore::ScrollbarThemeMac::preferencesChanged): Removed use of old user defaults.
+        (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay): Deleted.
+        (WebCore::ScrollbarThemeMac::autoscrollTimerDelay): Deleted.
+
 2019-06-25  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h

@@ -53 +53 @@
     void updateScrollbarOverlayStyle(Scrollbar&)  override;
 
-    Seconds initialAutoscrollTimerDelay() override;
-    Seconds autoscrollTimerDelay() override;
+    Seconds initialAutoscrollTimerDelay() override { return 500_ms; }
+    Seconds autoscrollTimerDelay() override { return 50_ms; }
 
     ScrollbarButtonsPlacement buttonsPlacement() const override;

trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm

@@ -137 +137 @@
 static const int cOuterButtonOverlap = 2;
 
-static Seconds gInitialButtonDelay { 500_ms };
-static Seconds gAutoscrollButtonDelay { 50_ms };
 static bool gJumpOnTrackClick = false;
 static bool gUsesOverlayScrollbars = false;
@@ -241 +239 @@
     NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
     [defaults synchronize];
-    gInitialButtonDelay = Seconds { [defaults floatForKey:@"NSScrollerButtonDelay"] };
-    gAutoscrollButtonDelay = Seconds { [defaults floatForKey:@"NSScrollerButtonPeriod"] };
     gJumpOnTrackClick = [defaults boolForKey:@"AppleScrollerPagingBehavior"];
     usesOverlayScrollbarsChanged();
@@ -284 +280 @@
 }
 
-Seconds ScrollbarThemeMac::initialAutoscrollTimerDelay()
-{
-    return gInitialButtonDelay;
-}
-
-Seconds ScrollbarThemeMac::autoscrollTimerDelay()
-{
-    return gAutoscrollButtonDelay;
-}
-    
 ScrollbarButtonsPlacement ScrollbarThemeMac::buttonsPlacement() const
 {