Changeset 246848 in webkit


Ignore:
Timestamp:
Jun 26, 2019 3:11:07 PM (5 years ago)
Author:
Ross Kirsling
Message:

[Win][MiniBrowser] Remove obsolete code after r246814.
https://bugs.webkit.org/show_bug.cgi?id=199233

Reviewed by Fujii Hironori.

  • MiniBrowser/win/MiniBrowserWebHost.cpp:

(MiniBrowserWebHost::didFinishLoadForFrame):
(SimpleEventListener::SimpleEventListener): Deleted.
(SimpleEventListener::handleEvent): Deleted.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r246829 r246848  
     12019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
     2
     3        [Win][MiniBrowser] Remove obsolete code after r246814.
     4        https://bugs.webkit.org/show_bug.cgi?id=199233
     5
     6        Reviewed by Fujii Hironori.
     7
     8        * MiniBrowser/win/MiniBrowserWebHost.cpp:
     9        (MiniBrowserWebHost::didFinishLoadForFrame):
     10        (SimpleEventListener::SimpleEventListener): Deleted.
     11        (SimpleEventListener::handleEvent): Deleted.
     12
    1132019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
    214
  • trunk/Tools/MiniBrowser/win/MiniBrowserWebHost.cpp

    r239812 r246848  
    3030#include "MiniBrowserWebHost.h"
    3131
    32 #include "DOMDefaultImpl.h"
    3332#include "PageLoadTestClient.h"
    3433#include "WebKitLegacyBrowserWindow.h"
    3534#include <WebKitLegacy/WebKit.h>
    36 
    37 class SimpleEventListener : public DOMEventListener {
    38 public:
    39     SimpleEventListener(LPWSTR type)
    40     {
    41         wcsncpy_s(m_eventType, 100, type, 100);
    42         m_eventType[99] = 0;
    43     }
    44 
    45     virtual HRESULT STDMETHODCALLTYPE handleEvent(IDOMEvent* evt)
    46     {
    47         wchar_t message[255];
    48         wcscpy_s(message, 255, m_eventType);
    49         wcscat_s(message, 255, L" event fired!");
    50         ::MessageBox(0, message, L"Event Handler", MB_OK);
    51         return S_OK;
    52     }
    53 
    54 private:
    55     wchar_t m_eventType[100];
    56 };
    5735
    5836typedef _com_ptr_t<_com_IIID<IWebDataSource, &__uuidof(IWebDataSource)>> IWebDataSourcePtr;
     
    139117}
    140118
    141 typedef _com_ptr_t<_com_IIID<IDOMDocument, &__uuidof(IDOMDocument)>> IDOMDocumentPtr;
    142 typedef _com_ptr_t<_com_IIID<IDOMElement, &__uuidof(IDOMElement)>> IDOMElementPtr;
    143 typedef _com_ptr_t<_com_IIID<IDOMEventTarget, &__uuidof(IDOMEventTarget)>> IDOMEventTargetPtr;
    144119typedef _com_ptr_t<_com_IIID<IWebFrame2, &__uuidof(IWebFrame2)>> IWebFrame2Ptr;
    145120
     
    158133    }
    159134
    160     IDOMDocumentPtr doc;
    161     frame->DOMDocument(&doc.GetInterfacePtr());
    162 
    163     IDOMElementPtr element;
    164     IDOMEventTargetPtr target;
    165 
    166135    if (m_client)
    167136        m_client->showLastVisitedSites(*webView);
    168137
    169     // The following is for the test page:
    170     static _bstr_t id = L"webkit logo";
    171     HRESULT hr = doc->getElementById(id, &element.GetInterfacePtr());
    172     if (!SUCCEEDED(hr))
    173         return hr;
    174 
    175     hr = element->QueryInterface(IID_IDOMEventTarget, reinterpret_cast<void**>(&target.GetInterfacePtr()));
    176     if (!SUCCEEDED(hr))
    177         return hr;
    178 
    179     static _bstr_t eventName = L"click";
    180     static _bstr_t eventType = L"webkit logo click";
    181     hr = target->addEventListener(eventName, new SimpleEventListener(eventType), FALSE);
    182     if (!SUCCEEDED(hr))
    183         return hr;
    184 
    185     return hr;
     138    return S_OK;
    186139}
    187140
Note: See TracChangeset for help on using the changeset viewer.