Changeset 246860 in webkit


Ignore:
Timestamp:
Jun 26, 2019 5:20:26 PM (5 years ago)
Author:
Basuke Suzuki
Message:

[RemoteInspector] Add address argument to listen for RemoteInspectorServer Socket implementation.
​https://bugs.webkit.org/show_bug.cgi?id=199035

Reviewed by Ross Kirsling.

Added new argument address to start listening.

  • inspector/remote/socket/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::start):

  • inspector/remote/socket/RemoteInspectorServer.h:
  • inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:

(Inspector::Socket::listen):

  • inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:

(Inspector::Socket::listen):

Location:
trunk/Source/JavaScriptCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r246851 r246860  
     12019-06-26  Basuke Suzuki  <Basuke.Suzuki@sony.com>
     2
     3        [RemoteInspector] Add address argument to listen for RemoteInspectorServer Socket implementation.
     4        https://bugs.webkit.org/show_bug.cgi?id=199035
     5
     6        Reviewed by Ross Kirsling.
     7
     8        Added new argument `address` to start listening.
     9
     10        * inspector/remote/socket/RemoteInspectorServer.cpp:
     11        (Inspector::RemoteInspectorServer::start):
     12        * inspector/remote/socket/RemoteInspectorServer.h:
     13        * inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
     14        (Inspector::Socket::listen):
     15        * inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:
     16        (Inspector::Socket::listen):
     17
    1182019-06-26  Keith Miller  <keith_miller@apple.com>
    219

  • trunk/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp

    r245536 r246860  
    133133}
    134134
    135 bool RemoteInspectorServer::start(uint16_t port)
     135bool RemoteInspectorServer::start(const char* address, uint16_t port)
    136136{
    137137    m_server = RemoteInspectorSocketEndpoint::create(this, "RemoteInspectorServer");
    138138
    139     if (!m_server->listenInet(nullptr, port)) {
     139    if (!m_server->listenInet(address, port)) {
    140140        m_server = nullptr;
    141141        return false;

  • trunk/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h

    r244919 r246860  
    4141    JS_EXPORT_PRIVATE static RemoteInspectorServer& singleton();
    4242
    43     JS_EXPORT_PRIVATE bool start(uint16_t);
     43    JS_EXPORT_PRIVATE bool start(const char* address, uint16_t port);
    4444    bool isRunning() const { return !!m_server; }
    4545

  • trunk/Source/JavaScriptCore/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp

    r245606 r246860  
    9393    // FIXME: Support AF_INET6 connections.
    9494    address.sin_family = AF_INET;
    95     if (addressStr)
     95    if (addressStr && *addressStr)
    9696        inet_aton(addressStr, &address.sin_addr);
    9797    else

  • trunk/Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp

    r244919 r246860  
    179179    struct sockaddr_in address = { };
    180180    address.sin_family = AF_INET;
    181     if (addressStr)
     181    if (addressStr && *addressStr)
    182182        ::inet_pton(AF_INET, addressStr, &address.sin_addr);
    183183    else
Note: See TracChangeset for help on using the changeset viewer.