Changeset 246882 in webkit


Ignore:
Timestamp:
Jun 27, 2019 9:10:01 AM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-build] Do not print worker environment variables in each build step
​https://bugs.webkit.org/show_bug.cgi?id=197319

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:

(CheckOutSource.init): Disabled logging of environment variables.
(ApplyPatch.init): Ditto.
(KillOldProcesses.init): Ditto.
(ArchiveBuiltProduct.init): Ditto.
(DownloadBuiltProduct.init): Ditto.
(ExtractBuiltProduct.init): Ditto.
(RunAPITests.init): Ditto.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/ews-build/steps.py

    r246823 r246882  
    9797                                                timeout=2 * 60 * 60,
    9898                                                alwaysUseLatest=True,
     99                                                logEnviron=False,
    99100                                                method='clean',
    100101                                                progress=True,
    … …  
    141142    haltOnFailure = True
    142143    command = ['Tools/Scripts/svn-apply', '--force', '.buildbot-diff']
     144
     145    def __init__(self, **kwargs):
     146        super(ApplyPatch, self).__init__(timeout=5 * 60, logEnviron=False, **kwargs)
    143147
    144148    def _get_patch(self):
    … …  
    762766
    763767    def __init__(self, **kwargs):
    764         super(KillOldProcesses, self).__init__(timeout=60, **kwargs)
     768        super(KillOldProcesses, self).__init__(timeout=60, logEnviron=False, **kwargs)
    765769
    766770
    … …  
    842846    haltOnFailure = True
    843847
     848    def __init__(self, **kwargs):
     849        super(ArchiveBuiltProduct, self).__init__(logEnviron=False, **kwargs)
     850
    844851
    845852class UploadBuiltProduct(transfer.FileUpload):
    … …  
    921928        return super(DownloadBuiltProduct, self).getResultSummary()
    922929
     930    def __init__(self, **kwargs):
     931        super(DownloadBuiltProduct, self).__init__(logEnviron=False, **kwargs)
     932
    923933
    924934class ExtractBuiltProduct(shell.ShellCommand):
    … …  
    930940    haltOnFailure = True
    931941    flunkOnFailure = True
     942
     943    def __init__(self, **kwargs):
     944        super(ExtractBuiltProduct, self).__init__(logEnviron=False, **kwargs)
    932945
    933946
    … …  
    941954               WithProperties('--%(configuration)s'), '--verbose', '--json-output={0}'.format(jsonFileName)]
    942955    failedTestsFormatString = '%d api test%s failed or timed out'
     956
     957    def __init__(self, **kwargs):
     958        super(RunAPITests, self).__init__(logEnviron=False, **kwargs)
    943959
    944960    def start(self):

  • trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

    r246822 r246882  
    414414            ExpectShell(workdir='wkdir',
    415415                        command=['python', 'Tools/BuildSlaveSupport/kill-old-processes', 'buildbot'],
     416                        logEnviron=False,
    416417                        timeout=60,
    417418                        )
    … …  
    426427            ExpectShell(workdir='wkdir',
    427428                        command=['python', 'Tools/BuildSlaveSupport/kill-old-processes', 'buildbot'],
     429                        logEnviron=False,
    428430                        timeout=60,
    429431                        )
    … …  
    10031005        self.expectRemoteCommands(
    10041006            ExpectShell(workdir='wkdir',
     1007                        logEnviron=False,
    10051008                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=ios-simulator',  '--release', 'archive'],
    10061009                        )
    … …  
    10161019        self.expectRemoteCommands(
    10171020            ExpectShell(workdir='wkdir',
     1021                        logEnviron=False,
    10181022                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=mac-sierra',  '--debug', 'archive'],
    10191023                        )
    … …  
    10921096        self.expectRemoteCommands(
    10931097            ExpectShell(workdir='wkdir',
     1098                        logEnviron=False,
    10941099                        command=['python', 'Tools/BuildSlaveSupport/download-built-product', '--release', 'https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-simulator-12-x86_64-release/1234.zip'],
    10951100                        )
    … …  
    11071112        self.expectRemoteCommands(
    11081113            ExpectShell(workdir='wkdir',
     1114                        logEnviron=False,
    11091115                        command=['python', 'Tools/BuildSlaveSupport/download-built-product', '--debug', 'https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/mac-sierra-x86_64-debug/123456.zip'],
    11101116                        )
    … …  
    11301136        self.expectRemoteCommands(
    11311137            ExpectShell(workdir='wkdir',
     1138                        logEnviron=False,
    11321139                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=ios-simulator',  '--release', 'extract'],
    11331140                        )
    … …  
    11431150        self.expectRemoteCommands(
    11441151            ExpectShell(workdir='wkdir',
     1152                        logEnviron=False,
    11451153                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=mac-sierra',  '--debug', 'extract'],
    11461154                        )
    … …  
    12141222        self.expectRemoteCommands(
    12151223            ExpectShell(workdir='wkdir',
     1224                        logEnviron=False,
    12161225                        command=['python', 'Tools/Scripts/run-api-tests', '--no-build', '--release', '--verbose', '--json-output={0}'.format(self.jsonFileName)],
    12171226                        logfiles={'json': self.jsonFileName},
    … …  
    12411250        self.expectRemoteCommands(
    12421251            ExpectShell(workdir='wkdir',
     1252                        logEnviron=False,
    12431253                        command=['python', 'Tools/Scripts/run-api-tests', '--no-build', '--debug', '--verbose', '--json-output={0}'.format(self.jsonFileName), '--ios-simulator'],
    12441254                        logfiles={'json': self.jsonFileName},
    … …  
    12681278        self.expectRemoteCommands(
    12691279            ExpectShell(workdir='wkdir',
     1280                        logEnviron=False,
    12701281                        command=['python', 'Tools/Scripts/run-api-tests', '--no-build', '--debug', '--verbose', '--json-output={0}'.format(self.jsonFileName)],
    12711282                        logfiles={'json': self.jsonFileName},
    … …  
    13091320        self.expectRemoteCommands(
    13101321            ExpectShell(workdir='wkdir',
     1322                        logEnviron=False,
    13111323                        command=['python', 'Tools/Scripts/run-api-tests', '--no-build', '--debug', '--verbose', '--json-output={0}'.format(self.jsonFileName)],
    13121324                        logfiles={'json': self.jsonFileName},
    … …  
    13641376        self.expectRemoteCommands(
    13651377            ExpectShell(workdir='wkdir',
     1378                        logEnviron=False,
    13661379                        command=['python', 'Tools/Scripts/run-api-tests', '--no-build', '--debug', '--verbose', '--json-output={0}'.format(self.jsonFileName)],
    13671380                        logfiles={'json': self.jsonFileName},
    … …  
    13811394        self.expectRemoteCommands(
    13821395            ExpectShell(workdir='wkdir',
     1396                        logEnviron=False,
    13831397                        command=['python', 'Tools/Scripts/run-api-tests', '--no-build', '--debug', '--verbose', '--json-output={0}'.format(self.jsonFileName)],
    13841398                        logfiles={'json': self.jsonFileName},

  • trunk/Tools/ChangeLog

    r246872 r246882  
     12019-06-27  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-build] Do not print worker environment variables in each build step
     4        https://bugs.webkit.org/show_bug.cgi?id=197319
     5
     6        Reviewed by Lucas Forschler.
     7
     8        * BuildSlaveSupport/ews-build/steps.py:
     9        (CheckOutSource.__init__): Disabled logging of environment variables.
     10        (ApplyPatch.__init__): Ditto.
     11        (KillOldProcesses.__init__): Ditto.
     12        (ArchiveBuiltProduct.__init__): Ditto.
     13        (DownloadBuiltProduct.__init__): Ditto.
     14        (ExtractBuiltProduct.__init__): Ditto.
     15        (RunAPITests.__init__): Ditto.
     16        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
     17
    1182019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
    219
Note: See TracChangeset for help on using the changeset viewer.