Changeset 246945 in webkit

Timestamp:

Jun 28, 2019 3:50:41 PM (5 years ago)

Author:

dino@apple.com

Message:

unable to build WebRTC for iOS Simulator
​https://bugs.webkit.org/show_bug.cgi?id=199337
<rdar://problem/52020841>

Reviewed by Tim Horton.

Run the compiled yasm with DYLD_ROOT_PATH=/
in order to convince dyld that it can load
the simulator binary on macOS.

• libwebrtc.xcodeproj/project.pbxproj:

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• libwebrtc.xcodeproj/project.pbxproj (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2019-06-28  Dean Jackson  <dino@apple.com>
+
+        unable to build WebRTC for iOS Simulator
+        https://bugs.webkit.org/show_bug.cgi?id=199337
+        <rdar://problem/52020841>
+
+        Reviewed by Tim Horton.
+
+        Run the compiled yasm with DYLD_ROOT_PATH=/
+        in order to convince dyld that it can load
+        the simulator binary on macOS.
+
+        * libwebrtc.xcodeproj/project.pbxproj:
+
 2019-06-27  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

@@ -3376 +3376 @@
                         filePatterns = asm;
                         fileType = sourcecode.asm.asm;
+                        inputFiles = (
+                        );
                         isEditable = 1;
                         outputFiles = (
                                 "${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o",
                         );
-                        script = "${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";
+                        script = "# This DYLD_ROOT_PATH hack is there to allow the yasm binary to run on macOS if it was built for another platform (e.g. iphonesimulator) - rdar://52020841 and rdar://50479465\nDYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";
                 };
 /* End PBXBuildRule section */