Changeset 247093 in webkit
- Timestamp:
- Jul 3, 2019 10:40:38 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r247086 r247093 1 2019-07-03 Andres Gonzalez <andresg_22@apple.com> 2 3 Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine. 4 https://bugs.webkit.org/show_bug.cgi?id=199434 5 <rdar://problem/52475140> 6 7 Reviewed by Chris Fleizach. 8 9 Disabled the tests that were passing for workaround. The workaround had 10 to be roll out cause it is hanging Safari. 11 * TestExpectations: 12 * platform/ios-wk2/TestExpectations: 13 1 14 2019-07-02 Fujii Hironori <Hironori.Fujii@sony.com> 2 15 -
trunk/LayoutTests/TestExpectations
r246824 r247093 2205 2205 ### START OF -disabled tests 2206 2206 2207 webkit.org/b/199431 accessibility/set-selected-text-range-after-newline.html [ Skip ] 2207 2208 webkit.org/b/20871 js/garbage-collect-after-string-appends.html [ Skip ] 2208 2209 webkit.org/b/58323 compositing/objects/composited-object-alignment.html [ Skip ] -
trunk/LayoutTests/platform/ios-wk2/TestExpectations
r247031 r247093 995 995 fast/replaced/border-radius-clip.html [ Failure ] 996 996 accessibility/ios-simulator/press-fires-touch-events.html [ Skip ] 997 webkit.org/b/199431 accessibility/ios-simulator/set-selected-text-range-after-newline.html [ Skip ] 997 998 998 999 fast/text/combining-character-sequence-vertical.html [ ImageOnlyFailure ] -
trunk/Source/WebCore/ChangeLog
r247089 r247093 1 2019-07-03 Andres Gonzalez <andresg_22@apple.com> 2 3 Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine. 4 https://bugs.webkit.org/show_bug.cgi?id=199434 5 <rdar://problem/52475140> 6 7 Reviewed by Chris Fleizach. 8 9 Tests were disabled until underlying bug is fixed. 10 11 Rolling out a workaround for CharacterIterator::advance bug because it 12 seems to be causing a hang in Safari. 13 * editing/Editing.cpp: 14 (WebCore::visiblePositionForIndexUsingCharacterIterator): 15 1 16 2019-07-02 Simon Fraser <simon.fraser@apple.com> 2 17 -
trunk/Source/WebCore/editing/Editing.cpp
r246653 r247093 1123 1123 it.advance(index - 1); 1124 1124 1125 if (!it.atEnd() && it.text()[0] == '\n') {1126 // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.1127 auto range = it.range();1128 if (range->startPosition() == range->endPosition()) {1129 it.advance(1);1130 if (!it.atEnd())1131 return VisiblePosition(it.range()->startPosition());1132 }1133 }1134 1135 1125 return { it.atEnd() ? range->endPosition() : it.range()->endPosition(), UPSTREAM }; 1136 1126 }
Note: See TracChangeset
for help on using the changeset viewer.