Changeset 247093 in webkit

Timestamp:

Jul 3, 2019 10:40:38 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
​https://bugs.webkit.org/show_bug.cgi?id=199434
<rdar://problem/52475140>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-03
Reviewed by Chris Fleizach.

Source/WebCore:

Tests were disabled until underlying bug is fixed.

Rolling out a workaround for CharacterIterator::advance bug because it
seems to be causing a hang in Safari.

• editing/Editing.cpp:

(WebCore::visiblePositionForIndexUsingCharacterIterator):

LayoutTests:

Disabled the tests that were passing for workaround. The workaround had
to be roll out cause it is hanging Safari.

• TestExpectations:
• platform/ios-wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• LayoutTests/platform/ios-wk2/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/Editing.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-07-03  Andres Gonzalez  <andresg_22@apple.com>
+
+        Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
+        https://bugs.webkit.org/show_bug.cgi?id=199434
+        <rdar://problem/52475140>
+
+        Reviewed by Chris Fleizach.
+
+        Disabled the tests that were passing for workaround. The workaround had
+        to be roll out cause it is hanging Safari.
+        * TestExpectations:
+        * platform/ios-wk2/TestExpectations:
+
 2019-07-02  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/LayoutTests/TestExpectations

@@ -2205 +2205 @@
 ### START OF -disabled tests
 
+webkit.org/b/199431 accessibility/set-selected-text-range-after-newline.html [ Skip ]
 webkit.org/b/20871 js/garbage-collect-after-string-appends.html [ Skip ]
 webkit.org/b/58323 compositing/objects/composited-object-alignment.html [ Skip ]

trunk/LayoutTests/platform/ios-wk2/TestExpectations

@@ -995 +995 @@
 fast/replaced/border-radius-clip.html [ Failure ]
 accessibility/ios-simulator/press-fires-touch-events.html [ Skip ]
+webkit.org/b/199431 accessibility/ios-simulator/set-selected-text-range-after-newline.html [ Skip ]
 
 fast/text/combining-character-sequence-vertical.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-03  Andres Gonzalez  <andresg_22@apple.com>
+
+        Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
+        https://bugs.webkit.org/show_bug.cgi?id=199434
+        <rdar://problem/52475140>
+
+        Reviewed by Chris Fleizach.
+
+        Tests were disabled until underlying bug is fixed.
+
+        Rolling out a workaround for CharacterIterator::advance bug because it
+        seems to be causing a hang in Safari.
+        * editing/Editing.cpp:
+        (WebCore::visiblePositionForIndexUsingCharacterIterator):
+
 2019-07-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/editing/Editing.cpp

@@ -1123 +1123 @@
     it.advance(index - 1);
 
-    if (!it.atEnd() && it.text()[0] == '\n') {
-        // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.
-        auto range = it.range();
-        if (range->startPosition() == range->endPosition()) {
-            it.advance(1);
-            if (!it.atEnd())
-                return VisiblePosition(it.range()->startPosition());
-        }
-    }
-
     return { it.atEnd() ? range->endPosition() : it.range()->endPosition(), UPSTREAM };
 }