Changeset 247105 in webkit
- Timestamp:
- Jul 3, 2019 2:20:04 PM (5 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 17 edited
- 1 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r247104 r247105 1 2019-07-03 Robin Morisset <rmorisset@apple.com> 2 3 [WHLSL] WHLSL::AST::Node is useless 4 https://bugs.webkit.org/show_bug.cgi?id=199391 5 6 Reviewed by Dean Jackson. 7 8 It has no member, no non-trivial method, and we never access an AST node completely generically. 9 So WHLSL::AST::Node can be removed, as a first step towards removing the virtual table pointer from most AST nodes (and avoiding a virtual destructor call at the end of the compiler). 10 11 No new test because there is no functional change. 12 13 * Modules/webgpu/WHLSL/AST/WHLSLAST.h: 14 * Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h: 15 * Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h: 16 * Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h: 17 * Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h: 18 * Modules/webgpu/WHLSL/AST/WHLSLNamedType.h: 19 * Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h: Renamed from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h. 20 (WebCore::WHLSL::AST::replaceWith): 21 * Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h: 22 * Modules/webgpu/WHLSL/AST/WHLSLType.h: 23 * Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h: 24 * Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h: 25 * Modules/webgpu/WHLSL/AST/WHLSLValue.h: 26 * Modules/webgpu/WHLSL/WHLSLNameResolver.cpp: 27 * Modules/webgpu/WHLSL/WHLSLParser.h: 28 * Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp: 29 * Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp: 30 * WebCore.xcodeproj/project.pbxproj: 31 1 32 2019-07-03 Youenn Fablet <youenn@apple.com> 2 33 -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
r245945 r247105 70 70 #include "WHLSLNativeFunctionDeclaration.h" 71 71 #include "WHLSLNativeTypeDeclaration.h" 72 #include "WHLSLNode.h"73 72 #include "WHLSLNullLiteral.h" 74 73 #include "WHLSLNullLiteralType.h" -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h
r239844 r247105 29 29 30 30 #include "WHLSLLexer.h" 31 #include "WHLSLNode.h"32 31 33 32 namespace WebCore { … … 37 36 namespace AST { 38 37 39 class BaseFunctionAttribute : public Node{38 class BaseFunctionAttribute { 40 39 public: 41 40 BaseFunctionAttribute(Lexer::Token&& origin) -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h
r239930 r247105 30 30 #include "WHLSLEntryPointType.h" 31 31 #include "WHLSLLexer.h" 32 #include "WHLSLNode.h"33 32 #include <wtf/Optional.h> 34 33 … … 44 43 class UnnamedType; 45 44 46 class BaseSemantic : public Node{45 class BaseSemantic { 47 46 public: 48 47 BaseSemantic(Lexer::Token&& origin) -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h
r245662 r247105 30 30 #include "WHLSLConstantExpression.h" 31 31 #include "WHLSLLexer.h" 32 #include "WHLSLNode.h"33 32 #include <wtf/Optional.h> 34 33 #include <wtf/Vector.h> … … 41 40 namespace AST { 42 41 43 class EnumerationMember : public Node{42 class EnumerationMember { 44 43 public: 45 44 EnumerationMember(Lexer::Token&& origin, String&& name, Optional<ConstantExpression>&& value = WTF::nullopt) -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h
r245945 r247105 31 31 #include "WHLSLFunctionAttribute.h" 32 32 #include "WHLSLLexer.h" 33 #include "WHLSLNode.h"34 33 #include "WHLSLSemantic.h" 35 34 #include "WHLSLUnnamedType.h" … … 44 43 namespace AST { 45 44 46 class FunctionDeclaration : public Node{45 class FunctionDeclaration { 47 46 public: 48 47 FunctionDeclaration(Lexer::Token&& origin, AttributeBlock&& attributeBlock, Optional<EntryPointType> entryPointType, UniqueRef<UnnamedType>&& type, String&& name, VariableDeclarations&& parameters, Optional<Semantic>&& semantic, bool isOperator) -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h
r239844 r247105 29 29 30 30 #include "WHLSLLexer.h" 31 #include "WHLSLNode.h"32 31 #include "WHLSLType.h" 33 32 #include <wtf/text/WTFString.h> -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h
r247104 r247105 34 34 namespace AST { 35 35 36 class Node {37 public:38 Node() = default;39 40 virtual ~Node() = default;41 42 explicit Node(const Node&) = default;43 Node(Node&&) = default;44 45 Node& operator=(const Node&) = default;46 Node& operator=(Node&&) = default;47 48 private:49 };50 51 36 template <typename New, typename Old, typename ...Args> 52 37 ALWAYS_INLINE New* replaceWith(Old& old, Args&&... args) … … 58 43 } 59 44 60 } // namespaceAST45 } } } // namespace WebCore::WHLSL::AST 61 46 62 } 63 64 } 65 66 #endif 47 #endif // ENABLE(WEBGPU) -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h
r239930 r247105 29 29 30 30 #include "WHLSLLexer.h" 31 #include "WHLSLNode.h"32 31 #include "WHLSLQualifier.h" 33 32 #include "WHLSLSemantic.h" … … 41 40 namespace AST { 42 41 43 class StructureElement : public Node{42 class StructureElement { 44 43 public: 45 44 StructureElement(Lexer::Token&& origin, Qualifiers&& qualifiers, UniqueRef<UnnamedType>&& type, String&& name, Optional<Semantic> semantic) -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h
r239844 r247105 28 28 #if ENABLE(WEBGPU) 29 29 30 #include "WHLSLNode.h"31 30 #include <wtf/TypeCasts.h> 32 31 … … 37 36 namespace AST { 38 37 39 class Type : public Node{38 class Type { 40 39 public: 41 40 Type() = default; -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h
r239930 r247105 30 30 #include "WHLSLLexer.h" 31 31 #include "WHLSLNamedType.h" 32 #include "WHLSLNode.h"33 32 #include "WHLSLUnnamedType.h" 34 33 #include <wtf/UniqueRef.h> -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h
r246550 r247105 29 29 30 30 #include "WHLSLLexer.h" 31 #include "WHLSLNode.h"32 31 #include "WHLSLType.h" 33 32 #include <wtf/UniqueRef.h> -
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h
r245945 r247105 28 28 #if ENABLE(WEBGPU) 29 29 30 #include "WHLSLNode.h"31 32 30 namespace WebCore { 33 31 … … 36 34 namespace AST { 37 35 38 class Value : public Node{36 class Value { 39 37 public: 40 38 Value(Lexer::Token&& origin) -
trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
r246700 r247105 40 40 #include "WHLSLProgram.h" 41 41 #include "WHLSLPropertyAccessExpression.h" 42 #include "WHLSLReplaceWith.h" 42 43 #include "WHLSLResolveOverloadImpl.h" 43 44 #include "WHLSLReturn.h" -
trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
r246135 r247105 64 64 #include "WHLSLNativeFunctionDeclaration.h" 65 65 #include "WHLSLNativeTypeDeclaration.h" 66 #include "WHLSLNode.h"67 66 #include "WHLSLNullLiteral.h" 68 67 #include "WHLSLNumThreadsFunctionAttribute.h" -
trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp
r247062 r247105 31 31 #include "WHLSLAST.h" 32 32 #include "WHLSLASTDumper.h" 33 #include "WHLSLReplaceWith.h" 33 34 #include "WHLSLVisitor.h" 34 35 -
trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp
r247062 r247105 40 40 #include "WHLSLPointerType.h" 41 41 #include "WHLSLReadModifyWriteExpression.h" 42 #include "WHLSLReplaceWith.h" 42 43 #include "WHLSLVariableDeclaration.h" 43 44 #include "WHLSLVariableReference.h" -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r247085 r247105 7129 7129 33503CA010179AD7003B47E1 /* JSNotification.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSNotification.h; sourceTree = "<group>"; }; 7130 7130 33503CC61017A1B1003B47E1 /* Notification.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Notification.cpp; sourceTree = "<group>"; }; 7131 3351F70B22CAD8DA0015B40D /* WHLSLReplaceWith.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLReplaceWith.h; sourceTree = "<group>"; }; 7131 7132 35C74FD3228A1912000C21A0 /* CSSGridIntegerRepeatValue.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = CSSGridIntegerRepeatValue.cpp; sourceTree = "<group>"; }; 7132 7133 35C74FD7228A19A6000C21A0 /* CSSGridIntegerRepeatValue.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CSSGridIntegerRepeatValue.h; sourceTree = "<group>"; }; … … 13328 13329 C21BF72221CD89DF00227979 /* WHLSLBuiltInSemantic.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLBuiltInSemantic.h; sourceTree = "<group>"; }; 13329 13330 C21BF72321CD89E100227979 /* WHLSLNativeFunctionDeclaration.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLNativeFunctionDeclaration.h; sourceTree = "<group>"; }; 13330 C21BF72421CD89E100227979 /* WHLSLNode.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLNode.h; sourceTree = "<group>"; };13331 13331 C21BF72521CD89E200227979 /* WHLSLArrayReferenceType.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLArrayReferenceType.h; sourceTree = "<group>"; }; 13332 13332 C21BF72621CD89E300227979 /* WHLSLEnumerationMember.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLEnumerationMember.h; sourceTree = "<group>"; }; … … 17133 17133 C21BF72321CD89E100227979 /* WHLSLNativeFunctionDeclaration.h */, 17134 17134 C21BF72A21CD89E700227979 /* WHLSLNativeTypeDeclaration.h */, 17135 C21BF72421CD89E100227979 /* WHLSLNode.h */,17136 17135 C21BF70721CD89C800227979 /* WHLSLNullLiteral.h */, 17137 17136 1CB69B3A21DF0403006E846A /* WHLSLNullLiteralType.cpp */, … … 17143 17142 C21BF71B21CD89D900227979 /* WHLSLReadModifyWriteExpression.h */, 17144 17143 C21BF70D21CD89CD00227979 /* WHLSLReferenceType.h */, 17144 3351F70B22CAD8DA0015B40D /* WHLSLReplaceWith.h */, 17145 17145 1CB69B3221DED40B006E846A /* WHLSLResolvableType.h */, 17146 17146 C2138A1521DDECE900F516BA /* WHLSLResourceSemantic.cpp */,
Note: See TracChangeset
for help on using the changeset viewer.