Changeset 247113 in webkit


Ignore:
Timestamp:
Jul 3, 2019 3:16:47 PM (5 years ago)
Author:
jer.noble@apple.com
Message:

Exception thrown from -[AVSampleBufferRenderSynchronizer addRenderer:], not a valid renderer.
https://bugs.webkit.org/show_bug.cgi?id=199419
<rdar://problem/52141139>

Reviewed by Eric Carlson.

Sometimes, -[AVSampleBufferDisplayLayer init] will return nil. When that happens, passing a nil
pointer to -addRenderer: will throw an exception.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r247110 r247113  
     12019-07-03  Jer Noble  <jer.noble@apple.com>
     2
     3        Exception thrown from -[AVSampleBufferRenderSynchronizer addRenderer:], not a valid renderer.
     4        https://bugs.webkit.org/show_bug.cgi?id=199419
     5        <rdar://problem/52141139>
     6
     7        Reviewed by Eric Carlson.
     8
     9        Sometimes, -[AVSampleBufferDisplayLayer init] will return nil. When that happens, passing a nil
     10        pointer to -addRenderer: will throw an exception.
     11
     12        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
     13        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
     14
    1152019-07-03  Robin Morisset  <rmorisset@apple.com>
    216
  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

    r245868 r247113  
    723723#endif
    724724
     725    ASSERT(m_sampleBufferDisplayLayer);
     726    if (!m_sampleBufferDisplayLayer) {
     727        ERROR_LOG(LOGIDENTIFIER, "Failed to create AVSampleBufferDisplayLayer");
     728        setNetworkState(MediaPlayer::DecodeError);
     729        return;
     730    }
     731
    725732    [m_synchronizer addRenderer:m_sampleBufferDisplayLayer.get()];
    726733    if (m_mediaSourcePrivate)
Note: See TracChangeset for help on using the changeset viewer.