Changeset 247126 in webkit
- Timestamp:
- Jul 3, 2019 6:13:08 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r247125 r247126 1 2019-07-03 Chris Dumez <cdumez@apple.com> 2 3 StorageManager::suspend() sometimes fails to call its completion handler 4 https://bugs.webkit.org/show_bug.cgi?id=199482 5 6 Reviewed by Youenn Fablet. 7 8 Make sure the completion handler gets called in the early return cases. 9 10 * NetworkProcess/WebStorage/StorageManager.cpp: 11 (WebKit::StorageManager::suspend): 12 1 13 2019-07-03 Youenn Fablet <youenn@apple.com> 2 14 -
trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp
r247094 r247126 925 925 void StorageManager::suspend(CompletionHandler<void()>&& completionHandler) 926 926 { 927 CompletionHandlerCallingScope completionHandlerCaller(WTFMove(completionHandler)); 927 928 if (!m_localStorageDatabaseTracker) 928 929 return; … … 933 934 m_state = State::WillSuspend; 934 935 935 m_queue->dispatch([this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] () mutable {936 m_queue->dispatch([this, protectedThis = makeRef(*this), completionHandler = completionHandlerCaller.release()] () mutable { 936 937 Locker<Lock> stateLocker(m_stateLock); 937 938 ASSERT(m_state != State::Suspended);
Note: See TracChangeset
for help on using the changeset viewer.