Changeset 247132 in webkit

Timestamp:

Jul 3, 2019 7:35:07 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Data Detectors are not working for context menus in clients that use the legacy preview API
​https://bugs.webkit.org/show_bug.cgi?id=199486
<rdar://problem/52117322>

Reviewed by Dean Jackson.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView assignLegacyDataForContextMenuInteraction]):
The Data Detectors code in the legacy preview path is guarded by a
#define that did not survive upstreaming. Remove it.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-03  Tim Horton  <timothy_horton@apple.com>
+
+        Data Detectors are not working for context menus in clients that use the legacy preview API
+        https://bugs.webkit.org/show_bug.cgi?id=199486
+        <rdar://problem/52117322>
+
+        Reviewed by Dean Jackson.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView assignLegacyDataForContextMenuInteraction]):
+        The Data Detectors code in the legacy preview path is guarded by a
+        #define that did not survive upstreaming. Remove it.
+
 2019-07-03  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -7663 +7663 @@
         ALLOW_DEPRECATED_DECLARATIONS_END
 
-#if USE(DATA_DETECTORS_FOR_DEFAULT_PREVIEW)
         // Previously, UIPreviewItemController would detect the case where there was no previewViewController
         // and create one. We need to replicate this code for the new API.
@@ -7682 +7681 @@
             return;
         }
-#endif
 
         auto menuTitle = titleForMenu(true, _showLinkPreviews, url, _positionInformation.title);