Changeset 247134 in webkit

Timestamp:

Jul 3, 2019 8:39:48 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

Crash in WebDragClient::startDrag because GraphicsContext is nullptr
​https://bugs.webkit.org/show_bug.cgi?id=199491

Reviewed by Wenson Hsieh.

Added a nullptr check.

Unfortunately no new tests since we don't have a reproducible test case.

• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-03  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Crash in WebDragClient::startDrag because GraphicsContext is nullptr
+        https://bugs.webkit.org/show_bug.cgi?id=199491
+
+        Reviewed by Wenson Hsieh.
+
+        Added a nullptr check.
+
+        Unfortunately no new tests since we don't have a reproducible test case.
+
+        * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
+        (WebKit::convertImageToBitmap):
+
 2019-07-03  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm

@@ -70 +70 @@
 
     auto graphicsContext = bitmap->createGraphicsContext();
+    if (!graphicsContext)
+        return nullptr;
 
     RetainPtr<NSGraphicsContext> savedContext = [NSGraphicsContext currentContext];