Changeset 247160 in webkit

Timestamp:

Jul 5, 2019 9:38:40 AM (5 years ago)

Author:

Tadeu Zagallo

Message:

Scribble Heap::m_worldState on destructor
​https://bugs.webkit.org/show_bug.cgi?id=199498

Reviewed by Sam Weinig.

The worldState is dumped when we crash due to a failed checkConn, and
this will make it clear if the heap has already been destroyed.

• heap/Heap.cpp:

(JSC::Heap::~Heap):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/Heap.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-07-05  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Scribble Heap::m_worldState on destructor
+        https://bugs.webkit.org/show_bug.cgi?id=199498
+
+        Reviewed by Sam Weinig.
+
+        The worldState is dumped when we crash due to a failed checkConn, and
+        this will make it clear if the heap has already been destroyed.
+
+        * heap/Heap.cpp:
+        (JSC::Heap::~Heap):
+
 2019-07-03  Sam Weinig  <weinig@apple.com>
 

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -340 +340 @@
 Heap::~Heap()
 {
+    // Scribble m_worldState to make it clear that the heap has already been destroyed if we crash in checkConn
+    m_worldState.store(0xbadbeef0u);
+
     forEachSlotVisitor(
         [&] (SlotVisitor& visitor) {