Changeset 247179 in webkit

Timestamp:

Jul 5, 2019 2:48:54 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: current call frame indicator not visible in dark mode
​https://bugs.webkit.org/show_bug.cgi?id=199047
<rdar://problem/51922895>

Reviewed by Timothy Hatcher.

• UserInterface/Views/CallFrameTreeElement.css:

(.tree-outline .item.call-frame .status > .status-image):
(.tree-outline .item.call-frame.selected .status > .status-image):
Replace the CSS variables used for fill with their actual color value (in light mode),
as the semantic "name" of the variable doesn't really match its usage. As an example, the
current call frame shouldn't rely on the value of --border-color, as it's not a "border".

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CallFrameTreeElement.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-07-05  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: current call frame indicator not visible in dark mode
+        https://bugs.webkit.org/show_bug.cgi?id=199047
+        <rdar://problem/51922895>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CallFrameTreeElement.css:
+        (.tree-outline .item.call-frame .status > .status-image):
+        (.tree-outline .item.call-frame.selected .status > .status-image):
+        Replace the CSS variables used for `fill` with their actual color value (in `light` mode),
+        as the semantic "name" of the variable doesn't really match its usage. As an example, the
+        current call frame shouldn't rely on the value of `--border-color`, as it's not a "border".
+
 2019-07-05  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css

@@ -53 +53 @@
     width: 17px;
     height: 17px;
-    fill: var(--border-color);
+    fill: hsl(0, 0%, 70%);
 }
 
 .tree-outline .item.call-frame.selected .status > .status-image {
-    fill: var(--border-color-dark);
+    fill: hsl(0, 0%, 57%);
 }