Changeset 247182 in webkit

Timestamp:

Jul 5, 2019 3:24:07 PM (5 years ago)

Author:

jer.noble@apple.com

Message:

Revert change to block playback when process is ostensibly "suspended".
​https://bugs.webkit.org/show_bug.cgi?id=199530

Reviewed by Eric Carlson.

In r243958, a drive-by-fix was added that blocked playback when the WebProcess thought it
was susposed to be suspended. The intent was to keep the AVAudioSession for the process
from being activated just before the process was suspended, and thus avoid receiving an
"interruption" and having the AVAudioSession deactivated out from under us upon resuming.

Unfortunately, this caused problems when another process resumes the WebContent process
in order to start playback; namely the Now Playing UI's play button. Because we may receive
the play command long before whe notice that we've been resumed, the WebContent process
may refuse to honor the play command because it thinks its supposed to be suspended.

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/PlatformMediaSessionManager.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-05  Jer Noble  <jer.noble@apple.com>
+
+        Revert change to block playback when process is ostensibly "suspended".
+        https://bugs.webkit.org/show_bug.cgi?id=199530
+
+        Reviewed by Eric Carlson.
+
+        In r243958, a drive-by-fix was added that blocked playback when the WebProcess thought it
+        was susposed to be suspended. The intent was to keep the AVAudioSession for the process
+        from being activated just before the process was suspended, and thus avoid receiving an
+        "interruption" and having the AVAudioSession deactivated out from under us upon resuming.
+
+        Unfortunately, this caused problems when another process resumes the WebContent process
+        in order to start playback; namely the Now Playing UI's play button. Because we may receive
+        the play command long before whe notice that we've been resumed, the WebContent process
+        may refuse to honor the play command because it thinks its supposed to be suspended.
+
+        * platform/audio/PlatformMediaSessionManager.cpp:
+        (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
+
 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp

@@ -210 +210 @@
     }
 
-    if (m_processIsSuspended) {
-        ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " returning false because process is suspended");
-        return false;
-    }
-
 #if USE(AUDIO_SESSION)
     if (activeAudioSessionRequired()) {