Changeset 24719 in webkit

Timestamp:

Jul 27, 2007 4:59:09 AM (17 years ago)

Author:

bdash

Message:

2007-07-27 Patrick Hanna <​phanna@email.unc.edu>

Reviewed by Darin Adler.

Change PluginBase::refresh to be static and update PluginsFunc::callAsFunction accordingly. Now we no longer
allocate an instance of a JSObject subclass on the stack which could lead to a crash during garbage collection.

• bindings/js/kjs_navigator.cpp: (KJS::PluginsFunc::callAsFunction):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/kjs_navigator.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-07-27  Patrick Hanna  <phanna@email.unc.edu>
+
+        Reviewed by Darin Adler.
+
+        Change PluginBase::refresh to be static and update PluginsFunc::callAsFunction accordingly. Now we no longer
+        allocate an instance of a JSObject subclass on the stack which could lead to a crash during garbage collection.
+
+        * bindings/js/kjs_navigator.cpp:
+        (KJS::PluginsFunc::callAsFunction):
+
 2007-07-27  Simon Hausmann  <hausmann@kde.org>
 

trunk/WebCore/bindings/js/kjs_navigator.cpp

@@ -72 +72 @@
         virtual ~PluginBase();
         
-        void refresh(bool reload);
+        static void refresh(bool reload);
 
     protected:
@@ -535 +535 @@
 JSValue *PluginsFunc::callAsFunction(ExecState *exec, JSObject *, const List &args)
 {
-    PluginBase(exec).refresh(args[0]->toBoolean(exec));
+    PluginBase::refresh(args[0]->toBoolean(exec));
     return jsUndefined();
 }