Changeset 247209 in webkit


Ignore:
Timestamp:
Jul 8, 2019 9:40:02 AM (5 years ago)
Author:
Claudio Saavedra
Message:

REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed
https://bugs.webkit.org/show_bug.cgi?id=199572

Reviewed by Michael Catanzaro.

The GError coming from the wrapped resolver shouldn't be freed,
but passed onto the caller.

  • NetworkProcess/glib/WebKitCachedResolver.cpp:

(webkitCachedResolverLookupByNameAsync):
(webkitCachedResolverLookupByNameWithFlagsAsync):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r247206 r247209  
     12019-07-08  Claudio Saavedra  <csaavedra@igalia.com>
     2
     3        REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed
     4        https://bugs.webkit.org/show_bug.cgi?id=199572
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        The GError coming from the wrapped resolver shouldn't be freed,
     9        but passed onto the caller.
     10
     11        * NetworkProcess/glib/WebKitCachedResolver.cpp:
     12        (webkitCachedResolverLookupByNameAsync):
     13        (webkitCachedResolverLookupByNameWithFlagsAsync):
     14
    1152019-07-07  Antoine Quint  <graouts@apple.com>
    216
  • trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp

    r246671 r247209  
    109109            g_task_return_pointer(task.get(), addressList, reinterpret_cast<GDestroyNotify>(g_resolver_free_addresses));
    110110        } else
    111             g_task_return_error(task.get(), error.get());
     111            g_task_return_error(task.get(), error.release().release());
    112112    }, task.leakRef());
    113113}
     
    171171            g_task_return_pointer(task.get(), addressList, reinterpret_cast<GDestroyNotify>(g_resolver_free_addresses));
    172172        } else
    173             g_task_return_error(task.get(), error.get());
     173            g_task_return_error(task.get(), error.release().release());
    174174    }, task.leakRef());
    175175}
Note: See TracChangeset for help on using the changeset viewer.