Changeset 247213 in webkit


Ignore:
Timestamp:
Jul 8, 2019 11:14:21 AM (5 years ago)
Author:
Chris Dumez
Message:

Unable to play videos on xfinity.com/stream on macOS Catalina
https://bugs.webkit.org/show_bug.cgi?id=199576
<rdar://problem/50101264>

Reviewed by Alex Christensen.

Source/WebCore:

Enable invalidate Fetch signal quirk for all sites as the blacklist is getting too large and
we are finding too much breakage too late in the release cycle.

  • Modules/fetch/FetchRequest.cpp:

(WebCore::processInvalidSignal):

  • page/Quirks.cpp:

(WebCore::Quirks::shouldIgnoreInvalidSignal const):

LayoutTests:

Rebaseline existing test.

  • http/wpt/fetch/request-abort-expected.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r247212 r247213  
     12019-07-08  Chris Dumez  <cdumez@apple.com>
     2
     3        Unable to play videos on xfinity.com/stream on macOS Catalina
     4        https://bugs.webkit.org/show_bug.cgi?id=199576
     5        <rdar://problem/50101264>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Rebaseline existing test.
     10
     11        * http/wpt/fetch/request-abort-expected.txt:
     12
    1132019-07-08  Antoine Quint  <graouts@apple.com>
    214
  • trunk/LayoutTests/http/wpt/fetch/request-abort-expected.txt

    r241265 r247213  
    1 CONSOLE MESSAGE: line 14: FetchRequestInit.signal should be undefined, null or an AbortSignal object.
    2 CONSOLE MESSAGE: line 28: FetchRequestInit.signal should be undefined, null or an AbortSignal object.
     1CONSOLE MESSAGE: line 14: FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release.
     2CONSOLE MESSAGE: line 28: FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release.
    33
    44PASS Request from URL with signal
  • trunk/Source/WebCore/ChangeLog

    r247211 r247213  
     12019-07-08  Chris Dumez  <cdumez@apple.com>
     2
     3        Unable to play videos on xfinity.com/stream on macOS Catalina
     4        https://bugs.webkit.org/show_bug.cgi?id=199576
     5        <rdar://problem/50101264>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Enable invalidate Fetch signal quirk for all sites as the blacklist is getting too large and
     10        we are finding too much breakage too late in the release cycle.
     11
     12        * Modules/fetch/FetchRequest.cpp:
     13        (WebCore::processInvalidSignal):
     14        * page/Quirks.cpp:
     15        (WebCore::Quirks::shouldIgnoreInvalidSignal const):
     16
    1172019-07-08  Youenn Fablet  <youenn@apple.com>
    218
  • trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp

    r243757 r247213  
    148148static inline Optional<Exception> processInvalidSignal(ScriptExecutionContext& context)
    149149{
    150     ASCIILiteral message { "FetchRequestInit.signal should be undefined, null or an AbortSignal object."_s };
     150    ASCIILiteral message { "FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release."_s };
    151151    context.addConsoleMessage(MessageSource::JS, MessageLevel::Warning, message);
    152152
  • trunk/Source/WebCore/page/Quirks.cpp

    r247191 r247213  
    9191bool Quirks::shouldIgnoreInvalidSignal() const
    9292{
    93     if (!needsQuirks())
    94         return false;
    95 
    96     auto host = m_document->topDocument().url().host();
    97     return equalLettersIgnoringASCIICase(host, "www.thrivepatientportal.com")
    98         || equalLettersIgnoringASCIICase(host, "www.bnz.co.nz")
    99         || equalLettersIgnoringASCIICase(host, "www.carvana.com");
     93    return needsQuirks();
    10094}
    10195
Note: See TracChangeset for help on using the changeset viewer.