Changeset 247227 in webkit

Timestamp:

Jul 8, 2019 12:54:50 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

WKWebView fails to render when another view uses CoreImage filters
​https://bugs.webkit.org/show_bug.cgi?id=199488
<rdar://problem/52695825>

Reviewed by Dean Jackson.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::layerHostingModeDidChange):
Update m_layerHostingMode when it changes, even if we can't message
the Web Content process. This ensures that the next time we launch
a Web Content process, WebPageCreationParameters will have the correct
layer hosting mode, and is the usual pattern for such things.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-08  Tim Horton  <timothy_horton@apple.com>
+
+        WKWebView fails to render when another view uses CoreImage filters
+        https://bugs.webkit.org/show_bug.cgi?id=199488
+        <rdar://problem/52695825>
+
+        Reviewed by Dean Jackson.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::layerHostingModeDidChange):
+        Update m_layerHostingMode when it changes, even if we can't message
+        the Web Content process. This ensures that the next time we launch
+        a Web Content process, WebPageCreationParameters will have the correct
+        layer hosting mode, and is the usual pattern for such things.
+
 2019-07-08  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -1848 +1848 @@
 void WebPageProxy::layerHostingModeDidChange()
 {
-    if (!hasRunningProcess())
-        return;
-
     LayerHostingMode layerHostingMode = pageClient().viewLayerHostingMode();
     if (m_layerHostingMode == layerHostingMode)
@@ -1856 +1853 @@
 
     m_layerHostingMode = layerHostingMode;
-    m_process->send(Messages::WebPage::SetLayerHostingMode(layerHostingMode), m_pageID);
+
+    if (hasRunningProcess())
+        m_process->send(Messages::WebPage::SetLayerHostingMode(layerHostingMode), m_pageID);
 }