Changeset 247237 in webkit


Ignore:
Timestamp:
Jul 8, 2019 4:49:10 PM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Debugger: there should be a different icon for URL breakpoints
https://bugs.webkit.org/show_bug.cgi?id=199550

Reviewed by Joseph Pecoraro.

Use the same (down|up) arrow icon for the Network Tab and the Network timeline.

  • UserInterface/Views/URLBreakpointTreeElement.js:

(WI.URLBreakpointTreeElement):

  • UserInterface/Views/URLBreakpointTreeElement.css:

(.breakpoint.url:not(.breakpoint-paused-icon) .icon): Added.

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel.prototype._addBreakpoint):

  • UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):

  • UserInterface/Images/URLBreakpoint.svg: Added.
Location:
trunk/Source/WebInspectorUI
Files:
1 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r247235 r247237  
     12019-07-08  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Debugger: there should be a different icon for URL breakpoints
     4        https://bugs.webkit.org/show_bug.cgi?id=199550
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Use the same (down|up) arrow icon for the Network Tab and the Network timeline.
     9
     10        * UserInterface/Views/URLBreakpointTreeElement.js:
     11        (WI.URLBreakpointTreeElement):
     12        * UserInterface/Views/URLBreakpointTreeElement.css:
     13        (.breakpoint.url:not(.breakpoint-paused-icon) .icon): Added.
     14
     15        * UserInterface/Views/DebuggerSidebarPanel.js:
     16        (WI.DebuggerSidebarPanel.prototype._addBreakpoint):
     17        * UserInterface/Views/SourcesNavigationSidebarPanel.js:
     18        (WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
     19
     20        * UserInterface/Images/URLBreakpoint.svg: Added.
     21
    1222019-07-08  Devin Rousso  <drousso@apple.com>
    223
  • trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js

    r246026 r247237  
    533533            constructor = WI.URLBreakpointTreeElement;
    534534
    535             if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint) {
    536                 options.className = WI.DebuggerSidebarPanel.AssertionIconStyleClassName;
     535            if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint)
    537536                options.title = WI.repeatedUIString.allRequests();
    538             }
    539537        } else {
    540538            let sourceCode = breakpoint.sourceCodeLocation && breakpoint.sourceCodeLocation.displaySourceCode;
  • trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js

    r246509 r247237  
    955955            constructor = WI.URLBreakpointTreeElement;
    956956
    957             if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint) {
    958                 options.className = "breakpoint-assertion-icon";
     957            if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint)
    959958                options.title = WI.repeatedUIString.allRequests();
    960             }
    961959        } else {
    962960            let sourceCode = breakpoint.sourceCodeLocation && breakpoint.sourceCodeLocation.displaySourceCode;
  • trunk/Source/WebInspectorUI/UserInterface/Views/URLBreakpointTreeElement.css

    r239703 r247237  
    2727    font-family: Menlo, monospace;
    2828}
     29
     30.breakpoint.url:not(.breakpoint-paused-icon) .icon {
     31    content: url(../Images/URLBreakpoint.svg);
     32}
  • trunk/Source/WebInspectorUI/UserInterface/Views/URLBreakpointTreeElement.js

    r247053 r247237  
    3030        console.assert(breakpoint instanceof WI.URLBreakpoint);
    3131
    32         if (!className)
    33             className = WI.BreakpointTreeElement.GenericLineIconStyleClassName;
     32        let classNames = ["breakpoint", "url"];
     33        if (className)
     34            classNames.push(className);
    3435
    3536        let subtitle;
     
    4243        }
    4344
    44         super(["breakpoint", "url", className], title, subtitle, breakpoint);
     45        super(classNames, title, subtitle, breakpoint);
    4546
    4647        this.status = WI.ImageUtilities.useSVGSymbol("Images/Breakpoint.svg");
Note: See TracChangeset for help on using the changeset viewer.