Changeset 247237 in webkit
- Timestamp:
- Jul 8, 2019 4:49:10 PM (5 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 1 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r247235 r247237 1 2019-07-08 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Debugger: there should be a different icon for URL breakpoints 4 https://bugs.webkit.org/show_bug.cgi?id=199550 5 6 Reviewed by Joseph Pecoraro. 7 8 Use the same (down|up) arrow icon for the Network Tab and the Network timeline. 9 10 * UserInterface/Views/URLBreakpointTreeElement.js: 11 (WI.URLBreakpointTreeElement): 12 * UserInterface/Views/URLBreakpointTreeElement.css: 13 (.breakpoint.url:not(.breakpoint-paused-icon) .icon): Added. 14 15 * UserInterface/Views/DebuggerSidebarPanel.js: 16 (WI.DebuggerSidebarPanel.prototype._addBreakpoint): 17 * UserInterface/Views/SourcesNavigationSidebarPanel.js: 18 (WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint): 19 20 * UserInterface/Images/URLBreakpoint.svg: Added. 21 1 22 2019-07-08 Devin Rousso <drousso@apple.com> 2 23 -
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
r246026 r247237 533 533 constructor = WI.URLBreakpointTreeElement; 534 534 535 if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint) { 536 options.className = WI.DebuggerSidebarPanel.AssertionIconStyleClassName; 535 if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint) 537 536 options.title = WI.repeatedUIString.allRequests(); 538 }539 537 } else { 540 538 let sourceCode = breakpoint.sourceCodeLocation && breakpoint.sourceCodeLocation.displaySourceCode; -
trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
r246509 r247237 955 955 constructor = WI.URLBreakpointTreeElement; 956 956 957 if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint) { 958 options.className = "breakpoint-assertion-icon"; 957 if (breakpoint === WI.domDebuggerManager.allRequestsBreakpoint) 959 958 options.title = WI.repeatedUIString.allRequests(); 960 }961 959 } else { 962 960 let sourceCode = breakpoint.sourceCodeLocation && breakpoint.sourceCodeLocation.displaySourceCode; -
trunk/Source/WebInspectorUI/UserInterface/Views/URLBreakpointTreeElement.css
r239703 r247237 27 27 font-family: Menlo, monospace; 28 28 } 29 30 .breakpoint.url:not(.breakpoint-paused-icon) .icon { 31 content: url(../Images/URLBreakpoint.svg); 32 } -
trunk/Source/WebInspectorUI/UserInterface/Views/URLBreakpointTreeElement.js
r247053 r247237 30 30 console.assert(breakpoint instanceof WI.URLBreakpoint); 31 31 32 if (!className) 33 className = WI.BreakpointTreeElement.GenericLineIconStyleClassName; 32 let classNames = ["breakpoint", "url"]; 33 if (className) 34 classNames.push(className); 34 35 35 36 let subtitle; … … 42 43 } 43 44 44 super( ["breakpoint", "url", className], title, subtitle, breakpoint);45 super(classNames, title, subtitle, breakpoint); 45 46 46 47 this.status = WI.ImageUtilities.useSVGSymbol("Images/Breakpoint.svg");
Note: See TracChangeset
for help on using the changeset viewer.