Changeset 247272 in webkit

Timestamp:

Jul 9, 2019 12:56:24 PM (5 years ago)

Author:

youenn@apple.com

Message:

Revert conditional WebPageProxy check to grant universal file read sandbox upon correct sandbox creation
​https://bugs.webkit.org/show_bug.cgi?id=199622
<rdar://problem/52357508>

Reviewed by Alex Christensen.

On iOS, the sandbox extension to '/' will usually fail, thus the universal file read sandbox is not granted.
This makes WebPageProxy cancel some ​file:// loads to the application own container.
As a short term fix, go back to previous behavior.
Covered by testing broken app identified in rdar://problem/52357508.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-09  Youenn Fablet  <youenn@apple.com>
+
+        Revert conditional WebPageProxy check to grant universal file read sandbox upon correct sandbox creation
+        https://bugs.webkit.org/show_bug.cgi?id=199622
+        <rdar://problem/52357508>
+
+        Reviewed by Alex Christensen.
+
+        On iOS, the sandbox extension to '/' will usually fail, thus the universal file read sandbox is not granted.
+        This makes WebPageProxy cancel some file:// loads to the application own container.
+        As a short term fix, go back to previous behavior.
+        Covered by testing broken app identified in rdar://problem/52357508.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+
 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -1059 +1059 @@
     ASSERT_WITH_SECURITY_IMPLICATION(!WebKit::isInspectorPage(*this));
 
-    if (SandboxExtension::createHandle("/", SandboxExtension::Type::ReadOnly, sandboxExtensionHandle))
-        willAcquireUniversalFileReadSandboxExtension(process);
+    // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508.
+    SandboxExtension::createHandle("/", SandboxExtension::Type::ReadOnly, sandboxExtensionHandle);
+    willAcquireUniversalFileReadSandboxExtension(process);
 }