Changeset 247290 in webkit

Timestamp:

Jul 9, 2019 6:31:03 PM (5 years ago)

Author:

Simon Fraser

Message:

[iOS WK2] Use Optional<> for two data members of WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=199637

Reviewed by Tim Horton.

Use Optional<CGSize> to replace _overridesViewLayoutSize/_viewLayoutSizeOverride
and _overridesMaximumUnobscuredSize/_maximumUnobscuredSizeOverride.

No behavior change.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView activeViewLayoutSize:]):
(-[WKWebView _frameOrBoundsChanged]):
(activeMaximumUnobscuredSize):
(-[WKWebView _minimumLayoutSizeOverride]):
(-[WKWebView _setViewLayoutSizeOverride:]):
(-[WKWebView _maximumUnobscuredSizeOverride]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _clearOverrideLayoutParameters]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (9 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-09  Simon Fraser  <simon.fraser@apple.com>
+
+        [iOS WK2] Use Optional<> for two data members of WKWebView
+        https://bugs.webkit.org/show_bug.cgi?id=199637
+
+        Reviewed by Tim Horton.
+
+        Use Optional<CGSize> to replace _overridesViewLayoutSize/_viewLayoutSizeOverride
+        and _overridesMaximumUnobscuredSize/_maximumUnobscuredSizeOverride.
+
+        No behavior change.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView activeViewLayoutSize:]):
+        (-[WKWebView _frameOrBoundsChanged]):
+        (activeMaximumUnobscuredSize):
+        (-[WKWebView _minimumLayoutSizeOverride]):
+        (-[WKWebView _setViewLayoutSizeOverride:]):
+        (-[WKWebView _maximumUnobscuredSizeOverride]):
+        (-[WKWebView _setMaximumUnobscuredSizeOverride:]):
+        (-[WKWebView _beginAnimatedResizeWithUpdates:]):
+        (-[WKWebView _clearOverrideLayoutParameters]):
+
 2019-07-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

@@ -284 +284 @@
 #endif
 
-    BOOL _overridesViewLayoutSize;
-    CGSize _viewLayoutSizeOverride;
+    Optional<CGSize> _viewLayoutSizeOverride;
     Optional<WebCore::FloatSize> _lastSentViewLayoutSize;
-    BOOL _overridesMaximumUnobscuredSize;
-    CGSize _maximumUnobscuredSizeOverride;
+    Optional<CGSize> _maximumUnobscuredSizeOverride;
     Optional<WebCore::FloatSize> _lastSentMaximumUnobscuredSize;
+
     CGRect _inputViewBounds;
     CGFloat _viewportMetaTagWidth;
@@ -2869 +2868 @@
 - (WebCore::FloatSize)activeViewLayoutSize:(const CGRect&)bounds
 {
-    if (_overridesViewLayoutSize)
-        return WebCore::FloatSize(_viewLayoutSizeOverride);
+    if (_viewLayoutSizeOverride)
+        return WebCore::FloatSize(_viewLayoutSizeOverride.value());
 
 #if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
@@ -2913 +2912 @@
 
     if (_dynamicViewportUpdateMode == WebKit::DynamicViewportUpdateMode::NotResizing) {
-        if (!_overridesViewLayoutSize)
+        if (!_viewLayoutSizeOverride)
             [self _dispatchSetViewLayoutSize:[self activeViewLayoutSize:self.bounds]];
-        if (!_overridesMaximumUnobscuredSize)
+        if (!_maximumUnobscuredSizeOverride)
             [self _dispatchSetMaximumUnobscuredSize:WebCore::FloatSize(bounds.size)];
 
@@ -3178 +3177 @@
 static WebCore::FloatSize activeMaximumUnobscuredSize(WKWebView *webView, const CGRect& bounds)
 {
-    return WebCore::FloatSize(webView->_overridesMaximumUnobscuredSize ? webView->_maximumUnobscuredSizeOverride : bounds.size);
+    return WebCore::FloatSize(webView->_maximumUnobscuredSizeOverride.valueOr(bounds.size));
 }
 
@@ -5918 +5917 @@
 #endif
 
+// Deprecated SPI.
 - (CGSize)_minimumLayoutSizeOverride
 {
-    ASSERT(_overridesViewLayoutSize);
-    return _viewLayoutSizeOverride;
+    ASSERT(_viewLayoutSizeOverride);
+    return _viewLayoutSizeOverride.valueOr(CGSizeZero);
 }
 
 - (void)_setViewLayoutSizeOverride:(CGSize)viewLayoutSizeOverride
 {
-    _overridesViewLayoutSize = YES;
     _viewLayoutSizeOverride = viewLayoutSizeOverride;
 
     if (_dynamicViewportUpdateMode == WebKit::DynamicViewportUpdateMode::NotResizing)
         [self _dispatchSetViewLayoutSize:WebCore::FloatSize(viewLayoutSizeOverride)];
-
 }
 
@@ -6021 +6019 @@
 }
 
+// Deprecated SPI
 - (CGSize)_maximumUnobscuredSizeOverride
 {
-    ASSERT(_overridesMaximumUnobscuredSize);
-    return _maximumUnobscuredSizeOverride;
+    ASSERT(_maximumUnobscuredSizeOverride);
+    return _maximumUnobscuredSizeOverride.valueOr(CGSizeZero);
 }
 
@@ -6030 +6029 @@
 {
     ASSERT(size.width <= self.bounds.size.width && size.height <= self.bounds.size.height);
-    _overridesMaximumUnobscuredSize = YES;
     _maximumUnobscuredSizeOverride = size;
 
@@ -6096 +6094 @@
     CGRect contentViewBounds = [_contentView bounds];
 
-    ASSERT_WITH_MESSAGE(!(_overridesViewLayoutSize && newViewLayoutSize.isEmpty()), "Clients controlling the layout size should maintain a valid layout size to minimize layouts.");
+    ASSERT_WITH_MESSAGE(!(_viewLayoutSizeOverride && newViewLayoutSize.isEmpty()), "Clients controlling the layout size should maintain a valid layout size to minimize layouts.");
     if (CGRectIsEmpty(newBounds) || newViewLayoutSize.isEmpty() || CGRectIsEmpty(futureUnobscuredRectInSelfCoordinates) || CGRectIsEmpty(contentViewBounds)) {
         [self _cancelAnimatedResize];
         [self _frameOrBoundsChanged];
-        if (_overridesViewLayoutSize)
+        if (_viewLayoutSizeOverride)
             [self _dispatchSetViewLayoutSize:newViewLayoutSize];
-        if (_overridesMaximumUnobscuredSize)
+        if (_maximumUnobscuredSizeOverride)
             [self _dispatchSetMaximumUnobscuredSize:WebCore::FloatSize(newMaximumUnobscuredSize)];
         if (_overridesInterfaceOrientation)
@@ -6309 +6307 @@
 - (void)_clearOverrideLayoutParameters
 {
-    _overridesViewLayoutSize = NO;
-    _viewLayoutSizeOverride = CGSizeZero;
-
-    _overridesMaximumUnobscuredSize = NO;
-    _maximumUnobscuredSizeOverride = CGSizeZero;
+    _viewLayoutSizeOverride = WTF::nullopt;
+    _maximumUnobscuredSizeOverride = WTF::nullopt;
 }