Changeset 247328 in webkit


Ignore:
Timestamp:
Jul 10, 2019 3:07:11 PM (5 years ago)
Author:
dbates@webkit.org
Message:

[iOS] Selection handles "Lollipops" can become gray and stay gray
https://bugs.webkit.org/show_bug.cgi?id=198852
<rdar://problem/51736130>

Reviewed by Wenson Hsieh.

Tell the text interaction assistant to update the selection UI when the tint color changes.
We do this by way of deactivating and activating selection.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView tintColorDidChange]):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r247326 r247328  
     12019-07-10  Daniel Bates  <dabates@apple.com>
     2
     3        [iOS] Selection handles "Lollipops" can become gray and stay gray
     4        https://bugs.webkit.org/show_bug.cgi?id=198852
     5        <rdar://problem/51736130>
     6
     7        Reviewed by Wenson Hsieh.
     8
     9        Tell the text interaction assistant to update the selection UI when the tint color changes.
     10        We do this by way of deactivating and activating selection.
     11
     12        * UIProcess/ios/WKContentViewInteraction.mm:
     13        (-[WKContentView tintColorDidChange]):
     14
    1152019-07-10  Dean Jackson  <dino@apple.com>
    216
  • trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

    r247326 r247328  
    29422942{
    29432943    [super tintColorDidChange];
     2944
     2945    BOOL shouldUpdateTextSelection = self.isFirstResponder && [self canShowNonEmptySelectionView];
     2946    if (shouldUpdateTextSelection)
     2947        [_textSelectionAssistant deactivateSelection];
    29442948    [self _updateInteractionTintColor];
     2949    if (shouldUpdateTextSelection)
     2950        [_textSelectionAssistant activateSelection];
    29452951}
    29462952
Note: See TracChangeset for help on using the changeset viewer.