Changeset 247365 in webkit


Ignore:
Timestamp:
Jul 11, 2019 2:15:24 PM (5 years ago)
Author:
timothy_horton@apple.com
Message:

Null deref of RenderView under FrameView::setNeedsCompositingConfigurationUpdate
https://bugs.webkit.org/show_bug.cgi?id=199723
<rdar://problem/51554747>

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::setNeedsCompositingConfigurationUpdate):
Add a null-check; it looks like it is possible to get here by dismissing
the find overlay (or other page overlay) at an inopportune time.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r247361 r247365  
     12019-07-11  Tim Horton  <timothy_horton@apple.com>
     2
     3        Null deref of RenderView under FrameView::setNeedsCompositingConfigurationUpdate
     4        https://bugs.webkit.org/show_bug.cgi?id=199723
     5        <rdar://problem/51554747>
     6
     7        Reviewed by Simon Fraser.
     8
     9        * page/FrameView.cpp:
     10        (WebCore::FrameView::setNeedsCompositingConfigurationUpdate):
     11        Add a null-check; it looks like it is possible to get here by dismissing
     12        the find overlay (or other page overlay) at an inopportune time.
     13
    1142019-07-11  Chris Dumez  <cdumez@apple.com>
    215
  • trunk/Source/WebCore/page/FrameView.cpp

    r247344 r247365  
    29222922{
    29232923    RenderView* renderView = this->renderView();
    2924     if (renderView->usesCompositing()) {
     2924    if (renderView && renderView->usesCompositing()) {
    29252925        if (auto* rootLayer = renderView->layer())
    29262926            rootLayer->setNeedsCompositingConfigurationUpdate();
Note: See TracChangeset for help on using the changeset viewer.