Changeset 247374 in webkit


Ignore:
Timestamp:
Jul 11, 2019 4:47:06 PM (5 years ago)
Author:
Chris Dumez
Message:

[iOS] fast/events/ios/rotation/orientationchange-event-listener-on.body.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=199732
<rdar://problem/52693087>

Reviewed by Alex Christensen.

Stop logging in each event listener to not be reliant on the order in which listener are called.
Instead, simply make sure all event listeners that should be called were actually called.

  • fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt:
  • fast/events/ios/rotation/orientationchange-event-listener-on.body.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r247373 r247374  
     12019-07-11  Chris Dumez  <cdumez@apple.com>
     2
     3        [iOS] fast/events/ios/rotation/orientationchange-event-listener-on.body.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=199732
     5        <rdar://problem/52693087>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Stop logging in each event listener to not be reliant on the order in which listener are called.
     10        Instead, simply make sure all event listeners that should be called were actually called.
     11
     12        * fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt:
     13        * fast/events/ios/rotation/orientationchange-event-listener-on.body.html:
     14
    1152019-07-11  Ryosuke Niwa  <rniwa@webkit.org>
    216
  • trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body-expected.txt

    r245086 r247374  
    55
    66Before rotation
    7 PASS In body's onorientationchange event handler
    8 PASS In window's orientationchange event listener
    9 PASS In body's onresize event handler
    10 PASS In window's resize event listener
    117After rotation
     8PASS eventListenerCalls is 4
    129PASS successfullyParsed is true
    1310
  • trunk/LayoutTests/fast/events/ios/rotation/orientationchange-event-listener-on.body.html

    r245086 r247374  
    3131            testRunner.runUIScript(getRotationUIScript(), function(result) {
    3232                debug('After rotation');
    33 
     33                shouldBe("eventListenerCalls", "4");
    3434                finishJSTest();
    3535            });
    3636        }
     37
     38        eventListenerCalls = 0;
    3739        window.addEventListener('resize', function() {
    38             testPassed("In window's resize event listener");
     40            ++eventListenerCalls;
    3941        }, false);
    4042
    4143        window.addEventListener('orientationchange', function() {
    42             testPassed("In window's orientationchange event listener");
     44            ++eventListenerCalls;
    4345        }, false);
    4446
    4547        document.body.addEventListener('resize', function() {
    4648            testFailed("In body's resize event listener");
     49            ++eventListenerCalls;
    4750        }, false);
    4851
    4952        document.body.addEventListener('orientationchange', function() {
    5053            testFailed("In body's orientationchange event listener");
     54            ++eventListenerCalls;
    5155        }, false);
    5256
    5357        function bodyOrientationChange()
    5458        {
    55             testPassed("In body's onorientationchange event handler");
     59            ++eventListenerCalls;
    5660        }
    5761
    5862        function bodyResize()
    5963        {
    60             testPassed("In body's onresize event handler");
     64            ++eventListenerCalls;
    6165        }
    6266
Note: See TracChangeset for help on using the changeset viewer.